Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] crash upon moon skipping (related to herbs) #3333

Open
selkirks opened this issue Jan 1, 2025 · 3 comments · May be fixed by #3390
Open

[BUG] crash upon moon skipping (related to herbs) #3333

selkirks opened this issue Jan 1, 2025 · 3 comments · May be fixed by #3390
Assignees

Comments

@selkirks
Copy link
Collaborator

selkirks commented Jan 1, 2025

Type of bug

Code - general bugs related to how the game runs and responds to you.

Description

i was moonskipping and the game crashed. expanded clan with a herb focus

Grade

Dire - Still playable, but a major feature is broken

Steps to reproduce the behavior

  1. make an expanded mode clan
  2. focus on herb gathering
  3. moon skip

Patrol ID + Outcome Print (if applicable)

No response

Commit # or Game Version Number

88ae28e

Additional context

Traceback (most recent call last):
File "C:\Users\Leafy\OneDrive\Documents\clangen stuff\clangen\main.py", line 331, in
game.all_screens[game.current_screen].on_use()
File "C:\Users\Leafy\OneDrive\Documents\clangen stuff\clangen\scripts\screens\EventsScreen.py", line 722, in on_use
self.loading_screen_on_use(self.events_thread, self.timeskip_done)
File "C:\Users\Leafy\OneDrive\Documents\clangen stuff\clangen\scripts\screens\Screens.py", line 178, in loading_screen_on_use
work_thread.join()
File "C:\Users\Leafy\OneDrive\Documents\clangen stuff\clangen\scripts\game_structure\propagating_thread.py", line 25, in join
raise self.exc
File "C:\Users\Leafy\OneDrive\Documents\clangen stuff\clangen\scripts\game_structure\propagating_thread.py", line 18, in run
self.ret = self._target(*self._args, **self._kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\Leafy\OneDrive\Documents\clangen stuff\clangen\scripts\screens\Screens.py", line 145, in _work_target
raise exp
File "C:\Users\Leafy\OneDrive\Documents\clangen stuff\clangen\scripts\screens\Screens.py", line 139, in _work_target
target(*args)
File "C:\Users\Leafy\OneDrive\Documents\clangen stuff\clangen\scripts\events.py", line 140, in one_moon
self.one_moon_cat(cat)
File "C:\Users\Leafy\OneDrive\Documents\clangen stuff\clangen\scripts\events.py", line 1055, in one_moon_cat
self.other_interactions(cat)
File "C:\Users\Leafy\OneDrive\Documents\clangen stuff\clangen\scripts\events.py", line 1920, in other_interactions
handle_short_events.handle_event(
File "C:\Users\Leafy\OneDrive\Documents\clangen stuff\clangen\scripts\events_module\short\handle_short_events.py", line 281, in handle_event
self.handle_herb_supply(block)
File "C:\Users\Leafy\OneDrive\Documents\clangen stuff\clangen\scripts\events_module\short\handle_short_events.py", line 792, in handle_herb_supply
for herb, count in herb_supply.entire_supply.copy():
^^^^^^^^^^^
ValueError: too many values to unpack (expected 2)

Screenshots

No response

@KiraDragoness
Copy link
Contributor

I'm getting this same crash without the herb focus. I've gotten it with both focus on feeding and "business as usual" focus. Eventually happens after skipping a bunch of moons, seems to be randomly.
I don't know if it can happen in classic mode, since I've only gotten it on expanded.

@rustykitty
Copy link
Contributor

/assign-me

Copy link

👋 Hey @rustykitty, thanks for your interest in this issue! 🎉

⚠ Note that this issue will become unassigned if it isn't closed within 7 days.

🔧 A maintainer can also add the 📌 Pinned label to prevent it from being unassigned automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants