[BUGFIX] fix incorrect dict iteration causing crash #3390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkgz
reviewed
Jan 28, 2025
| @@ -789,7 +789,7 @@ def handle_herb_supply(self, block): | |||
|
|
|||
| # adjust entire herb store | |||
| if supply_type == "all_herb": | |||
| for herb, count in herb_supply.entire_supply.items(): | |||
There was a problem hiding this comment.
It seems like this reverts the changes made in the first commit and described in the PR. Is this intentional?
j-gynn
reviewed
Jan 28, 2025
| @@ -801,6 +801,7 @@ def handle_herb_supply(self, block): | |||
| herb_supply.remove_herb(herb, count / 8) | |||
| elif "increase" in adjustment: | |||
| herb_supply.add_herb(herb, adjustment.split("_")[1]) | |||
| print("Ran without crashing yay") | |||
There was a problem hiding this comment.
Either update to a more useful comment or remove please (in context it makes sense but in an output log it's deeply unhelpful!)
There was a problem hiding this comment.
I'm planning to remove that print once I figure out how to get the code to trigger and successfully test the function.
There was a problem hiding this comment.
I have made this PR a draft since you are not ready for it to be merged in. Please revert it to open when you have tested and are comfortable with the changes made!
rustykitty
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
changed .copy to .items on iterating a dict.
Why This Is Good For ClanGen
N/A
Linked Issues
fixes #3333
Proof of Testing
wasn't able to get the code to trigger. idk why
Changelog/Credits