Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CODE] Refactor History class to use itself correctly #2528

Open
j-gynn opened this issue Jun 25, 2024 · 2 comments · May be fixed by #3392
Open

[CODE] Refactor History class to use itself correctly #2528

j-gynn opened this issue Jun 25, 2024 · 2 comments · May be fixed by #3392
Assignees
@rustykitty
Labels
📍 Assigned enhancement New features or Change to Existing Features

Comments

@j-gynn
Copy link
Collaborator

j-gynn commented Jun 25, 2024

Description
Currently, most functions in History take a Cat class item to do anything, and then proceed to refer to cat.history to do everything...... which is the History class. Refactor this to correctly use self and all calls to use cat.history.[whatever_we're_calling].
@j-gynn j-gynn added the enhancement New features or Change to Existing Features label Jun 25, 2024
@rustykitty
Copy link
Contributor

/assign-me

@github-actions GitHub Actions
Copy link

👋 Hey @rustykitty, thanks for your interest in this issue! 🎉

⚠ Note that this issue will become unassigned if it isn't closed within 7 days.

🔧 A maintainer can also add the 📌 Pinned label to prevent it from being unassigned automatically.

@rustykitty rustykitty linked a pull request Jan 30, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustykitty rustykitty

Labels
📍 Assigned enhancement New features or Change to Existing Features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CODE] refactor History class rustykitty/clangen
2 participants
@j-gynn @rustykitty