[CODE] refactor History class #3392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at class call load_history instead of check_load doing a history operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
As requested, refactored History class to use self, with the exception of two methods,
add_murdersandreveal_murder. I wasn't quite sure which cat's history to make theselfin those.It may not be the best idea to have to call load_history each time we want to do something with cat.history, but I have attempted to minimize the calls.
Why This Is Good For ClanGen
Linked Issues
resolves #2528
Proof of Testing
2025-02-07.06-46-29.mov
Changelog/Credits