Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content: Injury expansion #3335

Open
wants to merge 17 commits into
base: development
Choose a base branch
from

Conversation

Tiritirimatangi
Copy link
Collaborator

About The Pull Request

Establishes baseline injury pool for future new biome

Why This Is Good For ClanGen

Step towards new biome

Proof of Testing

Cannot test due to desert biome not being created.

resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
"m_c"
],
"injuries": [
"water in their lungs"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be changed somehow to be sand instead of water?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now no - in the future we can discuss adding new injuries?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it'll get reported as a bug a lot :( People will read that the cat should have sand in their lungs, but the condition will say it's water, which is confusing. I do think its a nice event though

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here me out: we leave this event as it is, and once the PR is merged to dev, create an issue about it and find a coder willing to fix it?

"leaf-bare"
],
"weight": 20,
"event_text": "The rains bounce off the hard-baked ground, leaving puddles and slippery mud literally everywhere. While the water is welcome, the lack of traction is not, and m_c grumbles when {PRONOUN/m_c/subject} {VERB/m_c/end/ends} up going arse over tail from a misstep.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc we use rump instead of arse

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does arse really count as a swear word? Will change if it does

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did look back through the chats and found a few discussions about it, the consensus seemed to be that it is

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuuuuuck really ugh. Okay, then I'll rewrite to a phrase that doesn't reference the 'falling tits over arse' saying

"m_c"
],
"scar": "Spiky spinifex started a fire that burned m_c.",
"reg_death": "Infected burns can be deadly.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this could use more detail, maybe include a bit about them being from the spinifex?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm I kinda like sometimes having short histories as well as long ones tho? I kept it short because spinifex starting fire with spontaneous combustion is kinda overly complicated to explain

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i get that! it just feels really abrupt the way it's currently written 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"reg_death": "Infected burns can be deadly.",
"reg_death": "Infected burns can be deadly, cutting m_c's life short.",

Okay! How's this?

resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
resources/lang/en/events/injury/desert.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants