-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content: Injury expansion #3335
base: development
Are you sure you want to change the base?
Content: Injury expansion #3335
Conversation
-fixed a bunch of typos -changed greenleaf nursery fire event weight to 20 -reworded some events to help them flow better and/or better convey intent
pronoun test please pass please
"m_c" | ||
], | ||
"injuries": [ | ||
"water in their lungs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be changed somehow to be sand instead of water?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now no - in the future we can discuss adding new injuries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it'll get reported as a bug a lot :( People will read that the cat should have sand in their lungs, but the condition will say it's water, which is confusing. I do think its a nice event though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here me out: we leave this event as it is, and once the PR is merged to dev, create an issue about it and find a coder willing to fix it?
"leaf-bare" | ||
], | ||
"weight": 20, | ||
"event_text": "The rains bounce off the hard-baked ground, leaving puddles and slippery mud literally everywhere. While the water is welcome, the lack of traction is not, and m_c grumbles when {PRONOUN/m_c/subject} {VERB/m_c/end/ends} up going arse over tail from a misstep.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc we use rump instead of arse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does arse really count as a swear word? Will change if it does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did look back through the chats and found a few discussions about it, the consensus seemed to be that it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fuuuuuck really ugh. Okay, then I'll rewrite to a phrase that doesn't reference the 'falling tits over arse' saying
"m_c" | ||
], | ||
"scar": "Spiky spinifex started a fire that burned m_c.", | ||
"reg_death": "Infected burns can be deadly.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this could use more detail, maybe include a bit about them being from the spinifex?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm I kinda like sometimes having short histories as well as long ones tho? I kept it short because spinifex starting fire with spontaneous combustion is kinda overly complicated to explain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i get that! it just feels really abrupt the way it's currently written 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"reg_death": "Infected burns can be deadly.", | |
"reg_death": "Infected burns can be deadly, cutting m_c's life short.", |
Okay! How's this?
About The Pull Request
Establishes baseline injury pool for future new biome
Why This Is Good For ClanGen
Step towards new biome
Proof of Testing
Cannot test due to desert biome not being created.