Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] add an in-game way to move cats to unknown residence #3382

Open
wants to merge 15 commits into
base: development
Choose a base branch
from

Conversation

rustykitty
Copy link
Contributor

About The Pull Request

added the "send to UR" button textures from LifeGen, slightly edited in GIMP to match what we're doing with the "exile to dark forest" button, added it to master_screen_scale, and added code to make the button work.

Note that I've hardcoded the "Is wandering the Unknown Residence" thought- that is for whoever decided to take on #3362 to localize.

Presently, moving a Clan cat to the Unknown Residence causes them to be marked as lost, as mentioned in the issue- this can be changed if desired.

Why This Is Good For ClanGen

Unknown Residence

Linked Issues

Resolves #2134

Proof of Testing

2025-01-25.09-02-24.mov

Changelog/Credits

Dead cats can now be moved to and from Unknown Residence

@rustykitty
Copy link
Contributor Author

rustykitty commented Jan 25, 2025

small bugfix

Screenshot 2025-01-25 at 11 50 53 AM

@rustykitty rustykitty marked this pull request as ready for review January 27, 2025 15:12
@larkgz
Copy link
Collaborator

larkgz commented Feb 1, 2025

I’ll take a closer look at this tomorrow, but would it be possible for you to request some new flavour text for the thoughts added in this PR from our writers in the Discord? I think there should be a little more unique flavour to it, and I’m worried that if we leave it for later it’ll be forgotten about because it’s a little out-of-the-way.

@rustykitty
Copy link
Contributor Author

I’ll take a closer look at this tomorrow, but would it be possible for you to request some new flavour text for the thoughts added in this PR from our writers in the Discord? I think there should be a little more unique flavour to it, and I’m worried that if we leave it for later it’ll be forgotten about because it’s a little out-of-the-way.

Well, I'm just mirroring what I see already in the code for moving cat to StarClan and the Dark Forest.

@larkgz
Copy link
Collaborator

larkgz commented Feb 5, 2025

@rustykitty The code looks good to me. Please make changes to the thoughts. At the very least, I’d want you to remove the term “unknown residence” from them because I don’t believe that this is a term that is supposed to exist in-universe.

Also, did you get approval from the LifeGen team to use their assets? I understand that technically the license allows it, but I don’t want anyone to feel like we’re taking their work without permission.

@rustykitty
Copy link
Contributor Author

rustykitty commented Feb 5, 2025

Also, did you get approval from the LifeGen team to use their assets? I understand that technically the license allows it, but I don’t want anyone to feel like we’re taking their work without permission.

Just did on Discord! https://discord.com/channels/1125069186985640063/1126707459650756678/1336506040031907951

EDIT: I will ask the writing team on Discord about the thoughts tomorrow morning

@rustykitty rustykitty changed the title [ENHANCEMENT] ingame way to move cats to unknown residence [ENHANCEMENT] add an in-game way to move cats to unknown residence Feb 6, 2025
resources/images/buttons/send_ur_hover.png Outdated Show resolved Hide resolved
resources/images/buttons/send_ur_unavailable.png Outdated Show resolved Hide resolved
resources/lang/en/screens/profile.en.json Outdated Show resolved Hide resolved
resources/theme/master_screen_scale.json Outdated Show resolved Hide resolved
@rustykitty rustykitty requested a review from j-gynn February 9, 2025 15:31
@rustykitty
Copy link
Contributor Author

Screenshot 2025-02-12 at 8 50 22 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingame way to move cats to UR
3 participants