[CONTENT] New Patrol (gen_train_app_newfriend1) #3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new solo General Training patrol for Apprentices in which they encounter an outsider. What'll happen? Nobody knows.
selkirks
requested changes
Feb 6, 2025
Fixed two instances in the newfriend patrol where app1 should've been p_l
j-gynn
requested changes
Feb 7, 2025
Co-authored-by: J Gynn <[email protected]>
Co-authored-by: J Gynn <[email protected]>
Co-authored-by: J Gynn <[email protected]>
Co-authored-by: J Gynn <[email protected]>
Co-authored-by: J Gynn <[email protected]>
Co-authored-by: J Gynn <[email protected]>
Co-authored-by: J Gynn <[email protected]>
Co-authored-by: J Gynn <[email protected]>
|
Went through and committed a few quick suggested changes. It's late for me, so I'm going to make this a draft for now and work on the stuff I want to pick apart later |
Co-authored-by: J Gynn <[email protected]>
Co-authored-by: J Gynn <[email protected]>
Co-authored-by: J Gynn <[email protected]>
|
One little request from my side: In the future, please make more meaningful commit titles. "Update " is really not indicative of what's changed. |
Sorry Arch. I was so focused on making the fixes that I didn't even think to change the titles. Will try to do better in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Added a new solo General Training patrol for Apprentices in which they encounter an outsider. What'll happen? Nobody knows.
Why This Is Good For ClanGen
It adds to the patrol pool, thus lowering the possibility of players getting the same patrol over and over again.
Proof of Testing
Changelog/Credits
Added new patrol