Use CXX_MODULE_STD #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausKlein
force-pushed
the
feature/use_cxx_module_std
branch
from
ccb4bc0 to
1343909
Compare
ClausKlein
force-pushed
the
feature/use_cxx_module_std
branch
from
27c6443 to
8e97be9
Compare
ClausKlein
commented
Jan 7, 2025
CMakeLists.txt
Outdated
| @@ -34,6 +35,7 @@ option(FMT_USE_MODULES "Export a CXX_MODULE fmt if possible" ${CMAKE_CXX_SCAN_FO | |||
| option(FMT_IMPORT_STD "Import the module std" ${FMT_USE_MODULES}) | |||
|
|
|||
| if(FMT_USE_MODULES) | |||
| set(CMAKE_CXX_SCAN_FOR_MODULES ON) | |||
There was a problem hiding this comment.
delete this line, see line 6
ClausKlein
commented
Jan 7, 2025
tests/CMakeLists.txt
Outdated
Comment on lines
83
to
89
| <<<<<<< HEAD | ||
| "-DCMAKE_CXX_MODULE_STD=${CMAKE_CXX_MODULE_STD}" | ||
| "-DCMAKE_EXPERIMENTAL_CXX_IMPORT_STD=${CMAKE_EXPERIMENTAL_CXX_IMPORT_STD}" | ||
| ======= | ||
| "-DCMAKE_CXX_MODULE_STD=ON" | ||
| "-DCMAKE_EXPERIMENTAL_CXX_IMPORT_STD=0e5b6991-d74f-4b3d-a41c-cf096e0b2508" | ||
| >>>>>>> 98c866a (Fix build problems with test module fmt) |
There was a problem hiding this comment.
merge garbage! remove it!
Use CXX_MODULE_STD Cleanup after rebase
ClausKlein
force-pushed
the
feature/use_cxx_module_std
branch
from
8e97be9 to
ba624a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.