Reject with error message if stream is missing #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. |
|
Hi, fair enough! Unfortunately I don’t have more bandwidth for this - so feel free to add, or to just close this PR. The effect is to replace errors like “cannot read property ‘pipe’ of undefined” with errors from upstream. We never consistently reproduced the upstream errors with a file, but a test could be written by mocking the call. |
|
Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #55, the
streamfromnode-stream-zipcan be undefined, and if so comes with an error.This PR causes calls to
node-stream-zipto rethrow that error. Read without whitespace for clarity.Feel free to do whatever you wish with this!