fix(react): pre-defined defaults to prevent infinite loops

ClearC2 · Feb 20, 2025 · 824086b · 824086b
1 parent f0aef3a
commit 824086b
Show file tree

Hide file tree

Showing 5 changed files with 54 additions and 24 deletions.
diff --git a/example/src/formSchema.json b/example/src/formSchema.json
@@ -112,7 +112,7 @@
               "::placeholder": {
                 "color": "orange"
               },
-              ":placeholder-shown": {
+              ":placeholderShown": {
                 "background": "orange"
               }
             }

diff --git a/src/FormBuilder.js b/src/FormBuilder.js
@@ -20,34 +20,43 @@ const debugLog = (...args) => {
   if (debug) console.log(...args) //eslint-disable-line
 }
 
+const defaults = {
+  object: {},
+  map: Map(),
+  nullFunction: () => null,
+  dropItemDimensions: {
+    h: 1,
+    w: 6
+  },
+  dropItemConfig: {
+    name: 'new-input',
+    label: 'New Field',
+    type: 'input'
+  },
+  device: {cordova: false, model: 'browser', platform: 'browser', uuid: 'browser', version: 'browser'}
+}
+
 const FormBuilder = (props) => {
   const {
     rowHeight,
     columns = 12,
-    formSchema = {},
+    formSchema = defaults.object,
     width,
     handleOnDimensionChange,
-    dropItemDimensions = {
-      h: 1,
-      w: 6
-    },
-    dropItemConfig = {
-      name: 'new-input',
-      label: 'New Field',
-      type: 'input'
-    },
+    dropItemDimensions = defaults.dropItemDimensions,
+    dropItemConfig = defaults.dropItemConfig,
     validate,
     requiredFlag,
     setContainerRef,
-    onClick = () => null,
-    handleOnDrop = () => null,
-    handleCascade = () => null,
-    handleRTEImageClick: onRTEImageClick = () => null,
-    handleLinkClick = () => null,
+    onClick = defaults.nullFunction,
+    handleOnDrop = defaults.nullFunction,
+    handleCascade = defaults.nullFunction,
+    handleRTEImageClick: onRTEImageClick = defaults.nullFunction,
+    handleLinkClick = defaults.nullFunction,
     conditionalFieldValues,
     conditionalSearch,
     inline,
-    handleOnChange = () => null,
+    handleOnChange = defaults.nullFunction,
     interactive = true,
     draggable = false,
     readonly,
@@ -62,8 +71,8 @@ const FormBuilder = (props) => {
     timeFormat = 'h:mm a',
     autoComplete = 'ac_off',
     style = {},
-    device = {cordova: false, model: 'browser', platform: 'browser', uuid: 'browser', version: 'browser'},
-    fieldDefinitions = Map(),
+    device = defaults.device,
+    fieldDefinitions = defaults.map,
     c2class
   } = props
   const [grid, updateGrid] = useState({layout: [], elements: []})

diff --git a/src/Inputs/ConditionalInput.js b/src/Inputs/ConditionalInput.js
@@ -3,8 +3,20 @@ import PropTypes from 'prop-types'
 import ConditionalDialog from './ConditionalDialog'
 import {Map, List, fromJS} from 'immutable'
 
+const defaults = {
+  object: {},
+  map: Map(),
+  nullFunction: () => null
+}
+
 const ConditionalInput = props => {
-  const {style = {}, name = '', value = Map(), values = Map(), onChange = () => null} = props
+  const {
+    style = defaults.object,
+    name = '',
+    value = defaults.map,
+    values = defaults.map,
+    onChange = defaults.nullFunction
+  } = props
 
   const {value: valueStyle = {}, inputOuter = {}, inputInner = {}, inputControl = {}, valueContainer = {}, indicators = {}} = style// eslint-disable-line
 

diff --git a/src/Inputs/Date/DateInput.js b/src/Inputs/Date/DateInput.js
@@ -9,6 +9,10 @@ import {randomId} from '../../utils'
 import ValidationErrorIcon from '../../ValidationErrorIcon'
 import useTheme from '../../theme/useTheme'
 
+const defaults = {
+  trueFunction: () => true
+}
+
 const DateInput = props => {
   const {
     name,
@@ -37,7 +41,7 @@ const DateInput = props => {
     futureYears = 12,
     minDate,
     maxDate,
-    onChangeValidator = () => true,
+    onChangeValidator = defaults.trueFunction,
     warning
   } = props
 

diff --git a/src/Inputs/Typeahead.js b/src/Inputs/Typeahead.js
@@ -126,6 +126,11 @@ class TypeaheadPerformanceOptimizer extends PureComponent {
   }
 }
 
+const defaults = {
+  nullFunction: () => null,
+  object: {}
+}
+
 const Typeahead = props => {
   const {
     name,
@@ -142,10 +147,10 @@ const Typeahead = props => {
     requiredWarning,
     required,
     tabIndex,
-    onKeyDown = () => null,
+    onKeyDown = defaults.nullFunction,
     draggable,
     persist = true,
-    typeahead = {},
+    typeahead = defaults.object,
     minChars = 1,
     stringify,
     autoComplete,
@@ -155,7 +160,7 @@ const Typeahead = props => {
     delimiter,
     isClearable = true,
     createlabel,
-    options: typeaheadOptions = {},
+    options: typeaheadOptions = defaults.object,
     warning
   } = props