Skip to content

Commit

Permalink
fix(datepicker): fix unnecessary dependency array (#233)
Browse files Browse the repository at this point in the history
  • Loading branch information
hargis32 authored Feb 4, 2025
1 parent 3819d16 commit a313045
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
2 changes: 1 addition & 1 deletion dist/es/Inputs/Date/DatePicker.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ var DatePicker = function DatePicker(props) {
changeShowPicker(false);
});
};
}, [elementId, minDate, maxDate, timePicker, determinePickerOpenDirection, startDate, handleOnChange, name, format, canPickYear, showCalendar, changeShowPicker]);
}, [elementId, timePicker, determinePickerOpenDirection, handleOnChange, name, format, changeShowPicker, showCalendar, canPickYear, minDate, maxDate]);
useEffect(function () {
initializePicker();
return function () {
Expand Down
13 changes: 11 additions & 2 deletions src/Inputs/Date/DatePicker.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,17 @@ const DatePicker = props => {
}
)
}
}, [elementId, minDate, maxDate, timePicker, determinePickerOpenDirection, startDate,
handleOnChange, name, format, canPickYear, showCalendar, changeShowPicker])
}, [elementId,
timePicker,
determinePickerOpenDirection,
handleOnChange,
name,
format,
changeShowPicker,
showCalendar,
canPickYear,
minDate,
maxDate])

useEffect(() => {
initializePicker()
Expand Down

0 comments on commit a313045

Please sign in to comment.