-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
107-add-starter-packs-packed #263
107-add-starter-packs-packed #263
Conversation
seanmunson
commented
Jan 11, 2025
•
edited
Loading
edited
- Needs more styling
- fix URL
- get bullet face of owner
- get checks to pass
- infinite scrolling / paging working
- alternate non-icon in lieu of avatar working
- pack originators with no avatars don't get a link to navigate to the list
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is coming together nicely. Issues:
|
Also, checks are still failing. |
…o 107-add-starter-packs-packed
That is a side effect of the on demand fetching on the backend that is happening. Maybe a simple count on the return will do? |
Everything looks great! Last request, can you de-hyperlink if the profile doesn't resolve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes functionality checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally it all looks quite good! Code has just a few small details to polish up before merging
…nmunson/ClearskyUI into 107-add-starter-packs-packed
Changes complete, ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes functionality checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanup looks good!