Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List counts #293

Merged
merged 35 commits into from
Feb 4, 2025
Merged

List counts #293

merged 35 commits into from
Feb 4, 2025

Conversation

thieflord06
Copy link
Member

@thieflord06 thieflord06 commented Jan 26, 2025 •
edited by noahm
Loading

fixes #188

thieflord06 and others added 30 commits November 27, 2024 23:40
@thieflord06
dev to main (v4.2.0) (#159)
1caa5b5
@noahm
Merge remote-tracking branch 'origin/dev'
85753ec
@thieflord06
Merge to main (#162)
2ba0338 
Includes only #161 to fix asset inclusion
@thieflord06
Merge dev to main (#170)
59abea3
@thieflord06
merge to main (4.4.0) (#183)
966d0a2
@thieflord06
add change.org petition link (#190)
e2d400b
@thieflord06
Merge to main (#193)
e3e7b75
@thieflord06
Merge to main (#194)
01eb6d3
@thieflord06
Merge into main 4.6.0 (#199)
87748b0
@thieflord06
Merge to main 4.7.0 (#200)
0970113
@thieflord06
merge to main (#207)
2574fd4
@noahm
add new useListSize hook
bd2db09
@thieflord06
merge to main 4.8.0 (#212)
91642ef
@thieflord06
Merge to main 4.9.0 (#219)
a73a46e 
Add hyperlinks in profile description (handle, email, external)
add placement
fix long handles pushing UI element out of view
@tb38r
virtualized list with react window & throttled the request to prevent…
87b9164 
… 429 errors
@tb38r
virtualized list with react window & throttled the request to prevent…
28edc62 
… 429 errors
@tb38r
fixed most issues,to address double windowing with react-window
aeadb6f
@tb38r
outstanding issue, list items not rendering
66df957
@tb38r
outstanding issue, list items not rendering
9d3a6ae
@tb38r
outstanding issue, list items not fully rendering
b0c953e
@tb38r
list count displayed, hook throttled to prevent server overload
f1291d7
@tb38r
list count displayed, hook throttled to prevent server overload
076aa61
@tb38r
list count displayed, hook throttled to prevent server overload
bca248f
@thieflord06
Merge to main (#245)
c237579 
Pending #244 investigation
@thieflord06
4.11.0: add count formatting // fix top 24 hour list display issue (#272
79dc93a 
)
@thieflord06
add spam indicator (#279)
daad373
@noahm
swap lodash.throttle for p-queue
a31c65b
@noahm
add a small loading indicator for list entry size
b6d0b30
@noahm
format list entry total
e75a25f
@noahm
tune up request rate limiting
a1bd248
noahm and others added 2 commits January 26, 2025 12:31
@noahm
use existing "poor-man's virtualization" for lists
48505f9
@thieflord06
Without virtualisation (#266)
1deef25 
Withheld working on the virtualisation element to get a viable working
product out.
Throttled getListSize to prevent server overload.
Updated with css changes from #264.
List count appears to the right of of the list name.
resolves #255.

![Screenshot 2025-01-14 at 17 38
38](https://github.com/user-attachments/assets/bf70d00d-5c2a-4861-92b6-110a9ca71258)
@vercel Vercel
Copy link

vercel bot commented Jan 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clearsky-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 8:21pm

@thieflord06 thieflord06 requested a review from noahm January 26, 2025 22:41
@thieflord06
Copy link
Member Author

video of issue:

Recording.2025-01-26.170415.mp4

noahm
noahm approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@noahm noahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all is working as expected now!

@noahm noahm enabled auto-merge February 4, 2025 20:25
@thieflord06
Copy link
Member Author

This issue is fixed.

@thieflord06 thieflord06 disabled auto-merge February 4, 2025 21:19
@thieflord06 thieflord06 merged commit 36de419 into dev Feb 4, 2025
3 checks passed
@thieflord06 thieflord06 deleted the list-counts branch February 4, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahm noahm noahm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display list count
3 participants
@thieflord06 @noahm @tb38r