Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

185 new tab format #294

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

seanmunson
Copy link
Contributor

@seanmunson seanmunson commented Jan 27, 2025

image

  • style colors
  • style button shapes
  • style selected / unselected
  • add opacity / transparency variation to selected tab.
  • reduce height of button slightly.
  • align arrows

Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clearsky-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 0:51am

Copy link
Member

@thieflord06 thieflord06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes functionality checks.

@thieflord06
Copy link
Member

thieflord06 commented Jan 28, 2025

After looking at this some more, can you add < > to the ends to indicate scrolling is available?

At least for mobile where the whole thing wouldn't usually show.

@thieflord06
Copy link
Member

thieflord06 commented Jan 29, 2025

I see that it does have arrows but it seems to only show at certain sizes.

Recording.2025-01-28.211836.mp4

@seanmunson
Copy link
Contributor Author

seanmunson commented Jan 29, 2025

So it looks like ... the Arrows only show when ...

a: There is scrolling to be done (and only on the side where there is 'extra' stuff off to that side)
b: The operation idiom is phone, not workstation

For what it's worth, the mobile-first model matches the operations on bluesky ... I will see what I can do to make it look 'scrollier' on mobile this morning.

To be fair, the more tabs we add the fewer times that there will be no arrows on both sides.

auto-merge was automatically disabled January 29, 2025 10:22

Head branch was pushed to by a user without write access

@seanmunson
Copy link
Contributor Author

Made arrows visible on mobile

It does look like both the arrows can't be made visible when at the extreme ends of the scroll range. Fortunately, it doesn't hop or jump or bump - it just makes the arrows invisible.

@thieflord06
Copy link
Member

Scrolling functionality has been lost.

@CrystalRiveraDesign
Copy link

I recommend changing the size of those dividers to only twice the size of the font used inside of them.
Via Discord, the Twitch tab reference is a great idea, putting a line underneath to highlight the chosen option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants