-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
185 new tab format #294
base: dev
Are you sure you want to change the base?
185 new tab format #294
Conversation
seanmunson
commented
Jan 27, 2025
•
edited
Loading
edited
- style colors
- style button shapes
- style selected / unselected
- add opacity / transparency variation to selected tab.
- reduce height of button slightly.
- align arrows
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes functionality checks.
After looking at this some more, can you add < > to the ends to indicate scrolling is available? At least for mobile where the whole thing wouldn't usually show. |
I see that it does have arrows but it seems to only show at certain sizes. Recording.2025-01-28.211836.mp4 |
So it looks like ... the Arrows only show when ... a: There is scrolling to be done (and only on the side where there is 'extra' stuff off to that side) For what it's worth, the mobile-first model matches the operations on bluesky ... I will see what I can do to make it look 'scrollier' on mobile this morning. To be fair, the more tabs we add the fewer times that there will be no arrows on both sides. |
…o 185-new-tab-formt
Head branch was pushed to by a user without write access
Made arrows visible on mobile It does look like both the arrows can't be made visible when at the extreme ends of the scroll range. Fortunately, it doesn't hop or jump or bump - it just makes the arrows invisible. |
Scrolling functionality has been lost. |
I recommend changing the size of those dividers to only twice the size of the font used inside of them. |