Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs and Help command #38

Merged
merged 2 commits into from
Jun 29, 2016
Merged

docs and Help command #38

merged 2 commits into from
Jun 29, 2016

Conversation

benadida
Copy link
Contributor

No description provided.

regexp string
example string
description string
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider adding a field of type func(*Message, [][]string) into this

Or, since some of the command objects would need additional state (JIRA client, etc.) switching command to an interface definition like

type Command interface {
    Regexp() string
    Example() string
    Description() string
    Handle(msg *Message, params [][]string)
}

@rgarcia
Copy link
Member

rgarcia commented Jun 29, 2016

lgtm

On Wed, Jun 29, 2016 at 2:43 PM, Ben Adida [email protected] wrote:

Assigned #38 #38 to @rgarcia
https://github.com/rgarcia.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#38 (comment), or mute the
thread
https://github.com/notifications/unsubscribe/AAEbz9hzdTqpvk_V_uyJ3ytGbGPpFxXtks5qQucSgaJpZM4JBmN6
.

@benadida
Copy link
Contributor Author

I like @rgarcia's way of making this more testable / modular! I will add that as a followup #39

@benadida benadida merged commit 35bb6fa into master Jun 29, 2016
@benadida benadida deleted the benadida/docs-v2 branch June 29, 2016 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants