Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make single column example run reproducibility test #3517

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

imreddyTeja
Copy link
Contributor

@imreddyTeja imreddyTeja commented Jan 10, 2025

Purpose

Create a reproducibility test for a single column run. This will be used to test the results of changing to a pure single column.

To-do

Content

Adds reproducibility test to the "single column hydrostatic balance float64" job


  • I have read and checked the items on the review checklist.

Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think we just need to

  • Add single_column_hydrostatic_balance_ft64 to the reproducibility_tests/reproducibility_test_job_ids.jl list, and
  • increment the ref counter

@imreddyTeja imreddyTeja force-pushed the tr/add-column-reproducibility-test branch from c1ab1d2 to 2479b5f Compare January 10, 2025 17:09
Update reproducibility ref counter
@imreddyTeja imreddyTeja force-pushed the tr/add-column-reproducibility-test branch from 2479b5f to 2991524 Compare January 10, 2025 18:22
@imreddyTeja imreddyTeja marked this pull request as ready for review January 15, 2025 17:22
@charleskawczynski charleskawczynski added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 52931f3 Jan 15, 2025
16 checks passed
@charleskawczynski charleskawczynski deleted the tr/add-column-reproducibility-test branch January 15, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants