Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ClimaTimeSteppers to latest version #3525

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

dennisYatunin
Copy link
Member

Purpose

This PR applies the DSS correction in CliMA/ClimaTimeSteppers.jl#348 to ClimaAtmos.


  • I have read and checked the items on the review checklist.

@dennisYatunin dennisYatunin requested a review from szy21 January 17, 2025 03:39
@dennisYatunin
Copy link
Member Author

Results seem to be unchanged, but maybe it would be good for @szy21 to take a look as well. I would expect a small improvement in conservation, but it could be too small to notice outside of the analytic mountain test.

Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and it looks like there is some improvement in mass conservation.

@dennisYatunin dennisYatunin force-pushed the dy/update_cts branch 3 times, most recently from 0be27f2 to e4541ed Compare January 19, 2025 02:25
@dennisYatunin dennisYatunin added this pull request to the merge queue Jan 19, 2025
Merged via the queue into main with commit 7bf913f Jan 19, 2025
20 of 22 checks passed
@dennisYatunin dennisYatunin deleted the dy/update_cts branch January 19, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants