Add optional toml_files kwarg to the BucketSimulation func
#1217
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
reviewed
Mar 5, 2025
| @@ -326,6 +326,7 @@ function setup_and_run(config_dict::AbstractDict) | |||
| energy_check = energy_check, | |||
| surface_elevation, | |||
| use_land_diagnostics, | |||
| toml_files, | |||
There was a problem hiding this comment.
It seems a little weird to me that the toml_files we pass to the bucket come from get_atmos_args. Can we either specify individual tomls for atmos and for land, or if we want them to be the same for both can we specify the tomls at the coupler level and pass them to both atmos and land?
There was a problem hiding this comment.
I agree, this is pretty hacky. Ideally we'd have one list of files that the coupler takes in and passes to both atmos and land but I wasn't sure how to accomplish that cleanly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
toml_filesoptional keyword argument toBucketSimulation. Iftoml_filesis not empty, it will be used to construct theBucketModelParameters. If it is empty (the default), behavior is unchanged.This PR modifies
setup_and_runandget_atmos_argsto passatmos_config_dict["toml"]toBucketSimulation.These changes will allow us to pass a calibration parameter file to the
BucketSimulationin order to calibrate bucket parameters. Closes #1216