Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override AbstractSoilHydrologyClosure broadcast behavior #869

Closed
wants to merge 1 commit into from

Conversation

imreddyTeja
Copy link
Contributor

@imreddyTeja imreddyTeja commented Oct 18, 2024

Purpose

Previously, the "Phase change source term" failed when run on a GPU.
Closes #860

The fix is adding
Base.broadcastable(BC::vanGenuchten) = Ref(BC)

I tried adding Base.broadcastable(BC::vanGenuchten) = tuple(BC) as suggested here, but that does not fix the error.

To-do

Content

  • isolated the problem to broadcasting over vanGenuchten struct
  • fixed by overriding the broadcast behavior for vanGenuchten struct
  • also applied the fix to BrooksCorey struct, even though it is not causing any failures

  • I have read and checked the items on the review checklist.

@imreddyTeja imreddyTeja marked this pull request as ready for review October 22, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Soil integration Tests fail when run on GPU
1 participant