Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce allocations in snow and neural snow #980

Merged
merged 1 commit into from
Jan 15, 2025
Merged

reduce allocations in snow and neural snow #980

merged 1 commit into from
Jan 15, 2025

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Jan 13, 2025 •
edited
Loading

Purpose

Closes #976

@a-charbon does this close 960 from your point of view? It may not be entirely general, but it works for the use cases we have

To-do

Content

  • I have read and checked the items on the review checklist.

@kmdeck kmdeck mentioned this pull request Jan 13, 2025
Closed
3 tasks
Sbozzolo
Sbozzolo approved these changes Jan 14, 2025
View reviewed changes
ext/neural_snow/NeuralSnow.jl Outdated Show resolved Hide resolved
@kmdeck kmdeck requested a review from a-charbon January 14, 2025 18:39
a-charbon
a-charbon approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@a-charbon a-charbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it closes the issue, we should leave it open as the redundancy remains (just in another way/place). However, this handles the allocation concerns and should be merged, and we can return to that issue another time.

@kmdeck kmdeck force-pushed the kd/snow_allocations_2 branch from 6f640e7 to f465762 Compare January 15, 2025 19:37
@kmdeck kmdeck force-pushed the kd/snow_allocations_2 branch from 286f950 to 2e98af1 Compare January 15, 2025 20:01
@kmdeck kmdeck merged commit ca2ad88 into main Jan 15, 2025
16 checks passed
@kmdeck kmdeck deleted the kd/snow_allocations_2 branch January 15, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-charbon a-charbon a-charbon approved these changes

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce allocations in snowy land
3 participants
@kmdeck @Sbozzolo @a-charbon