remove allocations in ground albedo of snowy land #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sbozzolo
reviewed
Jan 14, 2025
src/integrated/land.jl
Outdated
| @. p.scratch1 = | ||
| (1 - p.snow.snow_cover_fraction) * p.soil.PAR_albedo + | ||
| p.snow.snow_cover_fraction * ground.α_snow | ||
| return p.scratch1 |
There was a problem hiding this comment.
I think that this is a little risky. Other lines in the functions that call this function might modify the value of p.scratch, which would affect the result of this field.
We should try keeping the scope of scratch variables visible limited and assume that something else will overwrite them at the next line
Sbozzolo
approved these changes
Jan 15, 2025
kmdeck
force-pushed
the
kd/ground_albedo_inplace
branch
from
7050876 to
dbcfd05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes part of #976
To-do
Content