Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some revisitation of turbulent fluxes #80

Merged
merged 506 commits into from
Jun 20, 2024
Merged

Some revisitation of turbulent fluxes #80

merged 506 commits into from
Jun 20, 2024

Conversation

simone-silvestri
Copy link
Collaborator

This PR revisits surface fluxes to have them produce similar results to COARE 3.6.

In addition there are some OMIP-specific infrastructural changes

  • remove lakes and connected regions to bathymetry
  • add a transmissivity and latitude dependent albedo from Payne (1972)

an ongoing PR subjected to changes

@glwagner glwagner mentioned this pull request Jun 20, 2024
Open
@glwagner
Copy link
Member

This is passing. Should we merge? We have a bunch of bugs to addresss it seems so better to get this big PR merged sooner rather than later.

@simone-silvestri
Copy link
Collaborator Author

Sounds good

@simone-silvestri simone-silvestri merged commit 274bef9 into main Jun 20, 2024
9 checks passed
@simone-silvestri simone-silvestri deleted the ss/omip-simulation branch June 20, 2024 21:43
@simone-silvestri
Copy link
Collaborator Author

Oh shoot, I realized I changed h_data to z_data in the bathymetry file in another branch, not this one. I ll do a quick PR to change that name

simone-silvestri added a commit that referenced this pull request Jun 21, 2024
@simone-silvestri
Some fixes after PR #80 (#88)
2236a76 
* remove interpolate

* z_data instead of h_data

* add warning for longitude range

* small change

* forgot about old_h

* nmew_h -> new_z
@glwagner
Copy link
Member

Makes progress towards #28

@vtamsitt vtamsitt mentioned this pull request Jul 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glwagner glwagner glwagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simone-silvestri @glwagner