-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [extension] Adding provider and view for remaining webview features #619
Conversation
🔍 Code Review Summary❗ Attention Required: This push has potential issues. 🚨 Overview
🚨 Critical Issuessecurity (1 issues)1. Potential security risk with Content Security Policy (CSP)📁 File: extensions/vscode/src/SidebarProvider.ts 💡 Solution: Current Code: style-src ${webview.cspSource}'unsafe-inline'; Suggested Code: style-src ${webview.cspSource}; Test Cases10 file need updates to their tests. Run
Useful Commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider implementing the following changes to improve the code.
const csp = ` | ||
default-src 'none'; | ||
script-src ${webview.cspSource} 'nonce-${nonce}'; | ||
style-src ${webview.cspSource} 'unsafe-inline'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment: Potential security risk with Content Security Policy (CSP)
Solution: Remove 'unsafe-inline' from the CSP and use external stylesheets instead.
!! Make sure the following suggestion is correct before committing it !!
style-src ${webview.cspSource} 'unsafe-inline'; | |
style-src ${webview.cspSource}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SwapnilChand can you try to see if it still works with the above changes suggested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it works without the directive too just fine but we can ignore this as the code was already present within the ts file.
Enhance API Management and Chat Functionality
Introduce new API management and chat functionalities to the VSCode extension.
ApiManagementProvider
andApiManagementView
for managing API endpoints.ChatRepoProvider
andChatRepoView
to facilitate chat interactions with a repository.DocManagementProvider
andDocManagementView
for document management features.SidebarProvider
to include new commands for opening chat and document management views.Enhances user experience by providing streamlined access to API management, chat functionalities, and document management within the extension.
Refactor and Enhance VS Code Extension Activation
Improve the activation process of the Kaizen CloudCode extension by adding new features and organizing the code.
ApiManagementProvider
,ChatRepoProvider
, andDocManagementProvider
.This enhances the functionality of the extension, providing users with more integrated features and a smoother experience.
Original Description
None