-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add raw media type for model weights files #35
Conversation
fa32fe3
to
6f8ae28
Compare
Signed-off-by: Zhao Chen <[email protected]>
6f8ae28
to
5a0f075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not against adding something like this to the spec. Maybe we should consider using a more common media-type to represent that it's just a binary blob, though -- e.g. application/vnd.cnai.model.weight.v1.octet-stream
Thanks for your suggestion~ My intention with using "raw" was to convey that it hasn't been compressed or TARed. "Octet-stream" also makes sense, but from an ease-of-understanding perspective, "raw" might be slightly more intuitive. Do you think that is OK, or am I still missing something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This commit introduces a
application/vnd.cnai.model.weight.v1.raw
media type. This will be beneficial for large language models, as the model weight files are giant, with individual files reaching up to 10GB and total files nearing 1TB:Similar PR in oci-spec: https://github.com/opencontainers/image-spec/pull/1197/files