refactor: menu bar #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russtoku
requested changes
May 4, 2024
| {% block nav_secondary %} | ||
| <ul class="navbar-nav navbar-nav-secondary col-auto"> | ||
| <li class="nav-item"> |
There was a problem hiding this comment.
It's safe to remove this line item.
| id="navbaraccount-link"> | ||
| <span class="d-none d-md-none d-lg-inline"> | ||
| Profile |
There was a problem hiding this comment.
I think that the logged in user's first name should be kept to provide an indication as to who is logged in. This is accomplished with:
{% blocktrans with name=request.user.first_name|truncatechars:12 %}
Profile ({{ name }})
{% endblocktrans %}
However, if the logged in user doesn't have the First name and the Last name fields populated, the first name won't be shown.
| {% if request.user.is_authenticated %} | ||
| <li class="nav-item dropdown account-dropdown {% block nav_account %}{% endblock %}"> | ||
| <span class="d-none d-md-none d-lg-inline"> | ||
| Profile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors our menu bar to be a little nicer (in my opinion).
Before
After