New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final touches on Piscine #1312

Merged

illicitonion merged 2 commits into main from piscine-final-touches

Jan 16, 2025

Member

illicitonion commented Jan 16, 2025

What does this change?

Fold in actual projects
Adjust some timings, LOs, etc to make day plans and success pages all look about right.


          Final touches on Piscine

2f5a8e1

* Fold in actual projects
* Adjust some timings, LOs, etc to make day plans and success pages all
  look about right.

illicitonion requested a review from a team

January 16, 2025 12:56

netlify bot commented Jan 16, 2025 •

edited

Loading

✅ Deploy Preview for cyf-curriculum canceled.

Name	Link
🔨 Latest commit	`a4b8bb9`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-curriculum/deploys/678944345d211300086a7605

netlify bot commented Jan 16, 2025 •

edited

Loading

✅ Deploy Preview for cyf-launch ready!

Name	Link
🔨 Latest commit	`a4b8bb9`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-launch/deploys/67894434cc1dd9000893041a
😎 Deploy Preview	https://deploy-preview-1312--cyf-launch.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Jan 16, 2025 •

edited

Loading

✅ Deploy Preview for cyf-common ready!

Name	Link
🔨 Latest commit	`a4b8bb9`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-common/deploys/678944348f4ae400089582de
😎 Deploy Preview	https://deploy-preview-1312--cyf-common.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Jan 16, 2025 •

edited

Loading

✅ Deploy Preview for cyf-sdc ready!

Name	Link
🔨 Latest commit	`a4b8bb9`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-sdc/deploys/678944349b9de000086f003a
😎 Deploy Preview	https://deploy-preview-1312--cyf-sdc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Jan 16, 2025 •

edited

Loading

✅ Deploy Preview for cyf-programming ready!

Name	Link
🔨 Latest commit	`a4b8bb9`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-programming/deploys/67894434ce35420008827b3a
😎 Deploy Preview	https://deploy-preview-1312--cyf-programming.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 77 (🔴 down 22 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Jan 16, 2025 •

edited

Loading

✅ Deploy Preview for cyf-itd ready!

Name	Link
🔨 Latest commit	`a4b8bb9`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-itd/deploys/678944344acf960008c7948c
😎 Deploy Preview	https://deploy-preview-1312--cyf-itd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 100 (🟢 up 8 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Jan 16, 2025 •

edited

Loading

✅ Deploy Preview for cyf-piscine ready!

Name	Link
🔨 Latest commit	`a4b8bb9`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-piscine/deploys/678944345a6bc10008e9fc19
😎 Deploy Preview	https://deploy-preview-1312--cyf-piscine.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 85 (🔴 down 15 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Jan 16, 2025 •

edited

Loading

✅ Deploy Preview for cyf-tracks ready!

Name	Link
🔨 Latest commit	`a4b8bb9`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-tracks/deploys/67894434af77f3000845b8c9
😎 Deploy Preview	https://deploy-preview-1312--cyf-tracks.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SallyMcGrath approved these changes

View reviewed changes

Member

SallyMcGrath left a comment

Nice!!


          Merge branch 'main' into piscine-final-touches

a4b8bb9

illicitonion merged commit 8c33b30 into main

34 checks passed

illicitonion deleted the piscine-final-touches branch

January 16, 2025 17:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet