Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up register #1323

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Fix up register #1323

merged 5 commits into from
Jan 28, 2025

Conversation

illicitonion
Copy link
Member

@illicitonion illicitonion commented Jan 28, 2025

  • Rename courses to remove cyf- prefixes everywhere

Also add a check that courses have matching data.

  • Symlink submission-created across courses

Otherwise the Piscine doesn't get register events handled

This is hard-coded in the register handler.

Also add a check that courses have matching data.
Otherwise the Piscine doesn't get register events handled
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 6df32cf
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6798c4f89e11d5000875a1d1
😎 Deploy Preview https://deploy-preview-1323--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 12 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 6df32cf
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/6798c4f80848c90008648d9d
😎 Deploy Preview https://deploy-preview-1323--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 6df32cf
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/6798c4f8d325ae00081d9598

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit 6df32cf
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/6798c4f892416a0008b2477b
😎 Deploy Preview https://deploy-preview-1323--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 6df32cf
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/6798c4f80408930007459818
😎 Deploy Preview https://deploy-preview-1323--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 6df32cf
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/6798c4f8f3691c0008dbd6be
😎 Deploy Preview https://deploy-preview-1323--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit 6df32cf
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/6798c4f8aa41080008726aa2
😎 Deploy Preview https://deploy-preview-1323--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 6df32cf
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/6798c4f8d3cbaf0008ecf4f4
😎 Deploy Preview https://deploy-preview-1323--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@illicitonion illicitonion merged commit 162acc7 into main Jan 28, 2025
34 checks passed
@illicitonion illicitonion deleted the rename-course branch January 28, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants