Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

~Final tweaks to Piscine #1325

Merged
merged 1 commit into from
Jan 28, 2025
Merged

~Final tweaks to Piscine #1325

merged 1 commit into from
Jan 28, 2025

Conversation

illicitonion
Copy link
Member

  • Note that groups may be 2 people.
  • Add temporary block for talking through breaking down requirements. We hope to remove this in the future, but we would like our day plans to be accurate for the course we're delivering.
  • Move team-selection to happen before morning break.

@illicitonion
~Final tweaks to Piscine
2f7e0e6 
* Note that groups may be 2 people.
* Add temporary block for talking through breaking down requirements. We
  hope to remove this in the future, but we would like our day plans to
  be accurate for the course we're delivering.
* Move team-selection to happen before morning break.
@illicitonion illicitonion requested a review from a team January 28, 2025 15:50
@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 2f7e0e6
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6798fcc25da97c00083b68ba
😎 Deploy Preview https://deploy-preview-1325--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (🟢 up 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit 2f7e0e6
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/6798fcc27457a30008eb72ef
😎 Deploy Preview https://deploy-preview-1325--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 2f7e0e6
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/6798fcc25404360008cd3728
😎 Deploy Preview https://deploy-preview-1325--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 2f7e0e6
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/6798fcc244890300083426ba

@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 2f7e0e6
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/6798fcc2f4de240008ddd0ae
😎 Deploy Preview https://deploy-preview-1325--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit 2f7e0e6
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/6798fcc201fda90008eecafc
😎 Deploy Preview https://deploy-preview-1325--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 74 (🔴 down 13 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 2f7e0e6
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/6798fcc24780080008c39fac
😎 Deploy Preview https://deploy-preview-1325--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 2f7e0e6
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/6798fcc272ce220008b9eaa4
😎 Deploy Preview https://deploy-preview-1325--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

40thieves
40thieves approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@40thieves 40thieves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one question about where/if we're documenting the ticket break down

@illicitonion illicitonion merged commit 8f074a2 into main Jan 28, 2025
34 checks passed
@illicitonion illicitonion deleted the piscine-tweaks branch January 28, 2025 21:54
@40thieves 40thieves mentioned this pull request Jan 28, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@40thieves 40thieves 40thieves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Curriculum Planning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illicitonion @40thieves