Implementation of multiple-servers project #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@illicitonion Thoughts on the architecture of this? |
There was a problem hiding this comment.
The general shape looks great!
I'm looking forward to working out how we introduce the concept of an entire apache config in a digestable manner :D
We may want to introduce a small cache or something somewhere (either in the API servers or the Apache?) to better justify why we may be replicating them? Or maybe that's for a different project?
And we may even want to introduce the idea of a CDN for the static files?
I left a couple of random thoughts from skimming the code, but realise this isn't at code-review readiness yet :)
tgvashworth
force-pushed
the
impl/multiple-servers
branch
from
f9006a5 to
054f55d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View rendered multiple-servers/IMPLEMENTATION.md
View rendered multiple-servers/README.md