Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop php8.1 php8.2 #121

Merged
merged 8 commits into from
Feb 24, 2025
Merged

feat: drop php8.1 php8.2 #121

merged 8 commits into from
Feb 24, 2025

Conversation

SamMousa
Copy link
Collaborator

No description provided.

@SamMousa
Copy link
Collaborator Author

@TavoNiievez based on your earlier work I went ahead and created a PR to drop php < 8.3.
Furthermore I increased the phpstan level to 9 and fixed the errors.

Could you do a quick sanity check when you have time?

@SamMousa SamMousa marked this pull request as ready for review February 24, 2025 10:56
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall 👍 but please note exception types.

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall 👍 but please note exception types.

@SamMousa SamMousa merged commit 729e04d into master Feb 24, 2025
4 checks passed
@SamMousa SamMousa deleted the php8.3 branch February 24, 2025 15:24
@SamMousa SamMousa restored the php8.3 branch February 24, 2025 16:32
@SamMousa SamMousa deleted the php8.3 branch February 24, 2025 16:47
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants