-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Php cs fixer per2 #123
Php cs fixer per2 #123
Conversation
SamMousa
commented
Feb 24, 2025
•
edited
Loading
edited
- Add CS check to CI
This PR contains no manual changes; just the results of running these commands:
|
@TavoNiievez do we have a codeception wide coding standard? Or can I use PER2.0? |
@SamMousa No, you can go ahead with PER2.0. |
Please note that in the ActiveRecord interface ( public function haveRecord(string $model, array $attributes = []);
public function haveRecord(string $model, $attributes = []): mixed. in the module class Also in the Connector class we can now use an enum like the following: enum CleanMethod: string {
case RECREATE = 'recreate';
case FORCE_RECREATE = 'force_recreate';
case CLEAR = 'clear';
case MANUAL = 'manual';
} and we save ourselves from having multiple unrelated individual constants, plus we can type $responseCleanMethod and $requestCleanMethod with it. |
Yeah I'm not doing that just yet, it's a refactor that can happen in a minor release since it doesn't change the public API. |
@samdark @TavoNiievez I want to merge this. I realize it is suboptimal, since code style changes are always messy PRs.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |