-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker compose #126
base: master
Are you sure you want to change the base?
Add docker compose #126
Conversation
Should probably add some kind of |
I don't like doing composer install inside docker. You need the uid config etc and it's a hassle. It's reasonable to assume contributors have composer installed. I do like the test part. Here you could even mount a different volume for dependencies per PHP version. That way permissions are not relevant. Please mount the source as read only, with the exception of the output directory. Also, can we use some standard image instead of building our own? Alternatively we can build an image in this repo and reference it in the compose file. |
How do you plan on fixing different PHP versions having different dependencies? I may have php8.2 installed on my host OS, but I would like to run tests on php 8.4
that could be done.. presumably using volumes?
yup
who is going to maintain these images? I am not familiar with github actions as I predomionantly use Gitlab, so someone else needs to add actions to auto-update these images then |
I am not sure if I can mount source DIR as RO, as composer does need to write to it(remember composer.lock file) |
We should get it to write the The abstract reasoning for me is that:
You could even do something like:
What do you think? |
No description provided.