Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard layout improvements & bf banner #853

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Dashboard layout improvements & bf banner #853

merged 3 commits into from
Nov 8, 2024

Conversation

abaicus
Copy link
Contributor

@abaicus abaicus commented Nov 8, 2024

All Submissions:

Changes proposed in this Pull Request:

  • Improves overall dashboard layout and breakpoints;
  • Adds HMR for dashboard dev script;
  • Adds BF 2024 banners;

image

Closes codeinwp/optimole-service#1282.

How to test the changes in this Pull Request:

  1. The banners are restricted by the time period right now so you can comment this line out if you want them to display;
  2. Ensure that the top banner dismiss works fine;
  3. Ensure that the links have the proper UTM params mentioned here;

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@abaicus abaicus marked this pull request as ready for review November 8, 2024 11:31
@pirate-bot
Copy link
Collaborator

pirate-bot commented Nov 8, 2024

Plugin build for 43b63e9 is ready 🛎️!

@selul selul merged commit c1050ee into development Nov 8, 2024
10 of 12 checks passed
@selul selul deleted the bf-24 branch November 8, 2024 15:20
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.13.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants