Skip to content

Commit

Permalink
Merge pull request #130 from Codeinwp/fix/design-pack-error
Browse files Browse the repository at this point in the history
Fix/design pack error
  • Loading branch information
HardeepAsrani authored Aug 20, 2024
2 parents b224997 + 7f64415 commit 957e3ed
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test-php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- name: Setup PHP version
uses: shivammathur/setup-php@v2
with:
php-version: '7.1'
php-version: '7.2'
extensions: simplexml, mysql
tools: phpunit-polyfills
- name: Checkout source code
Expand All @@ -69,4 +69,4 @@ jobs:
- name: Install composer
run: composer install --prefer-dist --no-progress --no-suggest
- name: Run phpunit
run: phpunit
run: composer run-script phpunit
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ assets/js/build

languages/raft.pot

.DS_Store
.DS_Store
.phpunit.result.cache
4 changes: 3 additions & 1 deletion assets/js/src/design-pack-notice.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ import { createRoot } from '@wordpress/element';

import DesignPackNotice from './components/DesignPackNotice';

const container = document.getElementById( 'raft-design-pack-notice' );
const container = document.createElement( 'div' );
container.id = 'raft-design-pack-notice';
document.body.appendChild( container );

if ( container ) {
createRoot( container ).render( <DesignPackNotice /> );
Expand Down
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"format": "phpcbf --standard=phpcs.xml --report-summary --report-source -s --runtime-set testVersion 7.0- ",
"phpcs": "phpcs --standard=phpcs.xml -s --runtime-set testVersion 7.0-",
"lint": "composer run-script phpcs",
"phpcs-i": "phpcs -i"
"phpcs-i": "phpcs -i",
"phpunit": "phpunit"
}
}
2 changes: 0 additions & 2 deletions inc/Admin.php
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ public function add_fse_design_pack_notice() {
),
'designPackNoticeData'
);

echo '<div id="raft-design-pack-notice"></div>';
}

/**
Expand Down
5 changes: 5 additions & 0 deletions tests/bootstrap.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
define( 'RAFT_IGNORE_SOURCE_CHECK', true );

$_tests_dir = getenv( 'WP_TESTS_DIR' );

if ( class_exists( '\Yoast\PHPUnitPolyfills\Autoload' ) === false ) {
require_once dirname( dirname( __FILE__ ) ) . '/vendor/yoast/phpunit-polyfills/phpunitpolyfills-autoload.php';
}

if ( ! $_tests_dir ) {
$_tests_dir = '/tmp/wordpress-tests-lib';
}
Expand Down

0 comments on commit 957e3ed

Please sign in to comment.