Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: share link in first comment #1023

Merged
merged 12 commits into from
Feb 6, 2025
Merged

Conversation

girishpanchal30
Copy link
Contributor

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jan 8, 2025
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) labels Jan 8, 2025
@pirate-bot
Copy link
Contributor

pirate-bot commented Jan 8, 2025

Plugin build for 68950df is ready 🛎️!

Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not confident in the current checks for 'ROP_Pro_Facebook_Helper' existence. I left a suggestion about the hooks solution. Otherwise, we should put some checks for class existence where it is used.

@girishpanchal30
Copy link
Contributor Author

@Soare-Robert-Daniel Thank you for your review. I have verified the existence of the class wherever it is used.

@vytisbulkevicius vytisbulkevicius merged commit 181bbb1 into development Feb 6, 2025
7 checks passed
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 9.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants