fix: Avoid ESBuild destroying Proxy in __toESM #164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153
When transpiling typescript (or ESM) toa ESBuild, it translates imports in a way like this:
TypeScript:
JS:
As we can see, it created a complete new object using Object.create copying all individual properties over. This way it translates ESM modules to CJS during runtime respecting the
__esModule
flags. This completely destroys ourProxy
object representing our fake imported module.With this fix we ensure
Object.create
also will create again aProxy
object restoring our runtime dynamic module.