-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap Red-DiscordBot[postgres]
in quotes in Unix install docs
#4697
Wrap Red-DiscordBot[postgres]
in quotes in Unix install docs
#4697
Conversation
I would prefer if we add specifics to which of the supported OS need it and which commands need it... wouldn't want people running |
This seems to be well phrased to me. @Drapersniper |
you're missing a comma between "system" and "brackets". the lack of comma changes the whole meaning of that sentence imo. also what Draper said below. |
I would disagree as a user this only confuses me as It makes me question if I need it or not for my setup. If escaping is needed it should be on the OS specific command section and not a blanket warning at the top. |
@Drapersniper So you suggest to separate the macOS section from the generic Linux part since this applies at least to the macOS installation procedure? |
Haven't had a chance to look this in depth so I'm not sure which commands need escaping on which OS. The ambiguity at the moment is what concerns me, if it's just one command on one specific OS, then this should be added directly to the command, if it's not a 100% repo or different MacOS version have the need to it specifying the version where it is required should be the way we go about this. If it's a unsupported env then no change is needed if we aren't going to support it. |
It's about I experience this problem on my macOS This is a common setup and in addition to that there is no limited support stated in the documentation for these versions listed above.
As stated above this is a not a "blanket warning" and directly added to the respective section where this note applies. |
Could we just replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ensured that python -m pip install -U "Red-DiscordBot[postgres]"
works on cmd
, bash
, and zsh
(and I'm suspecting it will also work fine on any other shells too) and I've updated this PR appropriately.
Thanks for bringing our attention to this issue!
Red-DiscordBot[postgres]
in quotes in Linux/macOS installation docs
Red-DiscordBot[postgres]
in quotes in Linux/macOS installation docsRed-DiscordBot[postgres]
in quotes in Unix install docs
Type
Description of the changes
Just added an "attention" block inside of the Linux/macOS bot installation documention which highlights the necessity of escaping brackets in terminals.