Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Red-DiscordBot[postgres] in quotes in Unix install docs #4697

Merged

Conversation

elysweyr
Copy link
Contributor

@elysweyr elysweyr commented Dec 26, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Just added an "attention" block inside of the Linux/macOS bot installation documention which highlights the necessity of escaping brackets in terminals.

@Drapersniper
Copy link
Contributor

I would prefer if we add specifics to which of the supported OS need it and which commands need it...

wouldn't want people running pip install RedDiscordBot\[postgres\] on systems that don't need it

@elysweyr
Copy link
Contributor Author

elysweyr commented Dec 26, 2020

Depending on your system brackets may need to be escaped.

This seems to be well phrased to me. @Drapersniper

@owocado
Copy link
Contributor

owocado commented Dec 26, 2020

Depending on your system brackets may need to be escaped.

This seems to be well phrased to me. @Drapersniper

you're missing a comma between "system" and "brackets". the lack of comma changes the whole meaning of that sentence imo.

also what Draper said below.

@Drapersniper
Copy link
Contributor

Depending on your system brackets may need to be escaped.

This seems to be well phrased to me. @Drapersniper

I would disagree as a user this only confuses me as It makes me question if I need it or not for my setup.

If escaping is needed it should be on the OS specific command section and not a blanket warning at the top.

@elysweyr
Copy link
Contributor Author

@Drapersniper So you suggest to separate the macOS section from the generic Linux part since this applies at least to the macOS installation procedure?

@Drapersniper
Copy link
Contributor

@Drapersniper So you suggest to separate the macOS section from the generic Linux part since this applies at least to the macOS installation procedure?

Haven't had a chance to look this in depth so I'm not sure which commands need escaping on which OS. The ambiguity at the moment is what concerns me, if it's just one command on one specific OS, then this should be added directly to the command, if it's not a 100% repo or different MacOS version have the need to it specifying the version where it is required should be the way we go about this.

If it's a unsupported env then no change is needed if we aren't going to support it.

@elysweyr
Copy link
Contributor Author

elysweyr commented Dec 26, 2020

@Drapersniper

It's about
python -m pip install -U Red-DiscordBot[postgres]

I experience this problem on my macOS 10.15.7 (19H2) system using Terminal (2.10), iTerm2 (3.3.9) and the pre-installed zsh version ( 5.7.1 (x86_64-apple-darwin19.0)).

This is a common setup and in addition to that there is no limited support stated in the documentation for these versions listed above.

[...] not a blanket warning at the top.

As stated above this is a not a "blanket warning" and directly added to the respective section where this note applies.

@Flame442 Flame442 added Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Type: Enhancement Something meant to enhance existing Red features. labels Jan 8, 2021
@Jackenmen
Copy link
Member

Could we just replace python -m pip install -U Red-DiscordBot[postgres] command with python -m pip install -U "Red-DiscordBot[postgres]"? Will that fix the problem for zsh shell?

Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ensured that python -m pip install -U "Red-DiscordBot[postgres]" works on cmd, bash, and zsh (and I'm suspecting it will also work fine on any other shells too) and I've updated this PR appropriately.

Thanks for bringing our attention to this issue!

@Jackenmen Jackenmen added this to the 3.4.6 milestone Jan 29, 2021
@Jackenmen Jackenmen self-assigned this Jan 29, 2021
@Jackenmen Jackenmen changed the title Docs: added brackets escape note for Linux/macOS installation Wrap Red-DiscordBot[postgres] in quotes in Linux/macOS installation docs Jan 29, 2021
@Jackenmen Jackenmen changed the title Wrap Red-DiscordBot[postgres] in quotes in Linux/macOS installation docs Wrap Red-DiscordBot[postgres] in quotes in Unix install docs Jan 29, 2021
@Jackenmen Jackenmen merged commit 51c1711 into Cog-Creators:V3/develop Jan 29, 2021
@Cog-CreatorsBot Cog-CreatorsBot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Jan 29, 2021
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants