Typescript conversion of core/Util.js and core/LOUtil.js #11009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eszkadev
reviewed
Jan 24, 2025
dennisfrancis
force-pushed
the
private/dennisf/typescript-conversion
branch
from
99223b2 to
eefb34c
Compare
dennisfrancis
force-pushed
the
private/dennisf/typescript-conversion
branch
from
eefb34c to
1c0faa3
Compare
dennisfrancis
changed the title
dennisfrancis
force-pushed
the
private/dennisf/typescript-conversion
branch
2 times, most recently
from
2a8c277 to
cdb3154
Compare
Signed-off-by: Dennis Francis <[email protected]> Change-Id: If0b099eceab932b4a52ce0a68269fcd7d810bd9f
inside L.Util.requestAnimFrame unconditionally as we have already assuming the availability of window.requestAnimationFrame inside canvas-section container. Signed-off-by: Dennis Francis <[email protected]> Change-Id: Ifdf885452135346e1df5f3196d49f76b8d1f983a
Signed-off-by: Dennis Francis <[email protected]> Change-Id: If77f50074b002c8a7566daf61cac3b14474aa838
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I31b5328976c6b46a62542e5b1b69bc1148893db9
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I07fb6b479c93789f773857e15041c8c35ee8328a
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I56f870121ed2141f3ca3bb234531505d45f624df
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I18311f09a63e793fb58b4de44c0f6c58c69f0883
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I38e9ed1880fe965eb87af7dbd15634399bb0d77c
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I4e498d790ae88a1a1c363c98f5aff8e9204d751f
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I3c66e0a53b5a6dc697db7fe04acc2690758bec20
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I9aa332be5ce8bb9d40a9f51f11a2a12017225b2d
Signed-off-by: Dennis Francis <[email protected]> Change-Id: Ic7e4bfec7e751669b01ef29e151ce127da8334b1
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I97334911b9c3a826d6084ab2c79cf0eb6104760b
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I6810a413d693bd834c7993290772e3fff4c23f52
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I7445a2c3fa90effb958798f2f4e870f2c9acbcf9
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I2668d65f2c07a65df07dbd4cb7de3f1be0debbc0
dennisfrancis
force-pushed
the
private/dennisf/typescript-conversion
branch
from
cdb3154 to
8aeb459
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript conversion of core/Util.js and core/LOUtil.js.
Summary
This PR contains an incremental approch to typescript conversion of core/Util.js. The goal is to remove L.Util as soon as the usages of its legacy leaflet js content is removed and rename core/CoolUtil.ts to core/Util.ts. This PR also converts core/LOUtil.js to app/LOUtil.ts. In this case the js file is completely replaced by the typescript file.
This PR also includes one functional change of unconditionally using window.requestAnimationFrame inside the wrapper L.Util.requestAnimFrame() as we are assuming the availability of window.requestAnimationFrame in canvas section container anyway.
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay