Calc: Implement column row highlight feature

[GulsahKose]

Change-Id: I985b2fa7e4f59c44ca8cba00666959ff8c18d236

• Resolves: #
• Target version: master

Summary

TODO

• ...

Checklist

• I have run make prettier-write and formatted the code.
• All commits have Change-Id
• I have run tests with make check
• I have issued make run and manually verified that everything looks okay
• Documentation (manuals or wiki) has been updated or is not required

[Darshan-upadhyay1110]

To make this patch work we need this core patch : https://gerrit.libreoffice.org/c/core/+/180703

@pedropintosilva can you please help us here to add icon for lc_viewcolumnrowhighlighting.svg ? in Core there no icon preset for this function.

I am looking into the web but haven't got anything solid yet...

[pedropintosilva]

We need to create one that follows the same visual language as the others

[eszkadev]

I commented in the core patch. It should be done more on online side (core only sends on/off).
We draw here the highlight. @gokaysatir could give some pointers how to best implement that.

I guess something from this folder would help: https://github.com/CollaboraOnline/online/blob/master/browser/src/canvas/sections/OtherViewCellCursorSection.ts

[gokaysatir]

If there is a setting on the core side, we can save the toggle state on the core side. If there isn't a setting for this, then we may need to add one. Core side can be used to send only the toggle state, as Szymon suggested.

For the drawing when toggle is on we can:

• Add a function into CellCursorSection.ts file, like "drawHighlight".
• We can call the function from "onDraw" function of CellCursorSection.ts.
• I think we can use cell cursor's width and height, and also position for the highlighting.
• We can draw a semi-transparent rectangle that starts or overlaps with the cell cursor position and goes to the edges.
• We can also hide the highlights when the cell cursor is hidden (if we want to). If we call the new function inside the if statement that checks the cell cursor visibility, it should be enough.

We need to test this with frozen panes, scrolled sheet, merged cells and hidden cells i think.

Please let me know if this helps.

Thank you.

[eszkadev]

Does that work after we used reference marks for formula selection?

• activate highlight and test if it works
• edit some cell, write =SUM(, now select few cells (we will use reference marks)
• after formula was created, accept the cell value, go to some other cells, test if highlighting still works

I fear we need some update after we switch sheet, change cell selected (but I only looked at code)

[GulsahKose]

I works with formulas.

Screencast.from.2025-02-03.16-50-56.webm

[eszkadev]

we can also load old value on app load, this can be done in UIManager, similar to other things:

online/browser/src/control/Control.UIManager.js

Line 83 in 25dfda0

shouldUseNotebookbarMode: function() {

[eszkadev]

please notice we don't use .uno in dispatch commands to avoid confusion

[eszkadev]

these 2 lines shouldn't be needed (adding css class)
setHighlightMode should fire commandstatechange which will inform button about state change

[eszkadev]

code looks good :) thanks