UX iprovements on server audit dialog #11036
Conversation
| : { | ||
| id: 'auditerror', | ||
| type: 'fixedtext', | ||
| text: `${countErrors} issue${countErrors > 1 ? 's' : ''} found`, |
There was a problem hiding this comment.
We need translatable string, we do that by using special wrapping function: _('string to translate').
It has to be static text, any dynamic content should be provided by replacement of a variable mark like eg. %COUNT%.
If you need both single and plural form, please use 2 separate strings, not combine that in JS as it will not work with other languages.
example:
if (count === 1)
return _('1 issue found');
else
return _('%COUNT issues found').replaceAll('%COUNT%', number);
I'm not sure if it is exactly %var% maybe different style, please check within a code for examples
There was a problem hiding this comment.
Please checkout the new changes
banobepascal
force-pushed
the
private/banobepascal/server-audit-dialog-improvements
branch
from
843e52a to
697a214
Compare
-Added new stylings to the indicator to make it more distinct -Added both cases for no issues and errors plus count of issues -Added new check-mark icon for audit success Signed-off-by: Banobe Pascal <[email protected]> Change-Id: I26824bcc2cc1ec1c20257c12112822b6e5915b4e
banobepascal
force-pushed
the
private/banobepascal/server-audit-dialog-improvements
branch
from
697a214 to
b1c1e92
Compare
|
@pedropintosilva please review |
There was a problem hiding this comment.
I didn't see any functional problem and since this introduces a new string I would like to see it merge so, I'm approving it. However I still don't think the following is good:
- The indicator protrudes from the UI and it might look like a button
- There is border on border situation going on there
- I'm not sure about using an x that is white
By making it a bit more subtle it would be already an improvement :
Still, probably improving the icon would be a welcome change
Change-Id: I6c91fb915d6abd6dfd93536fdde6a2835091b6f5
Summary
Screenshots
With no Issues
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay