Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for ComboBox acrylic background #307

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Workaround for ComboBox acrylic background #307

merged 1 commit into from
Nov 8, 2023

Conversation

shatyuka
Copy link
Contributor

@shatyuka shatyuka commented Nov 8, 2023

Force ShouldConstrainToRootBounds to True using Microsoft.Xaml.Behaviors.

@shatyuka shatyuka added Bug Something isn't working Area: Launcher Issue labeled for Launcher update mechanism Area: UI/UX Issue labeled for User Interface/eXperience related issue labels Nov 8, 2023
@shatyuka shatyuka requested a review from bagusnl November 8, 2023 11:45
@shatyuka shatyuka self-assigned this Nov 8, 2023
bagusnl
bagusnl approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@bagusnl bagusnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me

@bagusnl
Copy link
Member

bagusnl commented Nov 8, 2023

Everything is all good. Really thankful for the fix.

This shouldn't be a case but MS doing MS stuff, sorry for putting you up on this. Merging

@bagusnl bagusnl merged commit ab93824 into CollapseLauncher:net-8 Nov 8, 2023
1 check passed
@neon-nyan neon-nyan added this to the v1.72.x milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagusnl bagusnl bagusnl approved these changes

Assignees

@shatyuka shatyuka

Labels
Area: Launcher Issue labeled for Launcher update mechanism Area: UI/UX Issue labeled for User Interface/eXperience related issue Bug Something isn't working
Projects
None yet
Milestone
v1.72.x
Development

Successfully merging this pull request may close these issues.
3 participants
@shatyuka @bagusnl @neon-nyan