Preview 1.82.16 Hotfix Release #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ This to ensure that the thread for other hashing routines to be available
Also remove early null check on Get###Hash methods
100% reviewed source file: 'en_US.json' on 'zh_CN'.
+ Also fix rare race condition where the launcher will reports "KeyNotFoundException" while getting CurrentGameProperty on cached GameVault
Why did I do this in the first place? It's already a reference type tho 🤦
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied ☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -15,6 +15,7 @@ | |||
| using System.Collections.Generic; | |||
| using System.Diagnostics.CodeAnalysis; | |||
| using System.IO; | |||
| using System.Runtime.CompilerServices; | |||
Check warning
Code scanning / QDNET
Redundant using directive Warning
|
PS: Duplicated code warning in SQ can be ignored, this happens due to XAML and JSON handler codes (mostly) that can't be deduplicated |
- Switch to more thread-safe CanvasVirtualImageSource. - This canvas type can be used in non-UI thread and can be shared between other threads while drawing frames. - Though, the canvas still need to be disposed in the UI thread. - Fix compilation error while enabling FFmpeg as MediaSource. - Ignore throwing on FrameGrabberEvent only on release build. - Fix crash while InterpolateVolumeChange is performing volume change when _currentMediaPlayer is null. - Always ignore alpha channel. - Pre-cached drawing area of the canvas. - Favor to use Task instead of ValueTask for some methods
+ This allows other frames to be skipped if the first frame doesn't have enough time to be drawn between other frames (in some cases, devices with lower specs).
|
|
As per internal discussion, this PR will be merged to preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed? - 1.82.16
SoftwareBitmaptoCanvasDeviceandCanvasBitmapto draw video frames while "Acrylic Effect" mode enabled.SoftwareBitmap, and instead use Direct3D-basedCanvasBitmapas the frame source.Templates
Changelog Prefixes