Change CsWinRT provider #121
8355 new problems found by Qodana for .NET
Qodana for .NET
8355 new problems were found
Inspection name | Severity | Problems |
---|---|---|
Unexpected text token error |
🔴 Failure | 83 |
Redundant using directive |
🔶 Warning | 1094 |
Auto-property accessor is never used (non-private accessibility) |
🔶 Warning | 494 |
Namespace does not correspond to file location |
🔶 Warning | 297 |
Method return value is never used (private accessibility) |
🔶 Warning | 284 |
Unused parameter (private accessibility) |
🔶 Warning | 215 |
Type member is never used (private accessibility) |
🔶 Warning | 139 |
Possible 'System.NullReferenceException' |
🔶 Warning | 135 |
Async method invocation without await expression |
🔶 Warning | 82 |
Invalid XML documentation comment |
🔶 Warning | 58 |
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. |
🔶 Warning | 40 |
Redundant namespace alias |
🔶 Warning | 40 |
Redundant 'partial' modifier on type declaration |
🔶 Warning | 39 |
Static resource not resolved |
🔶 Warning | 34 |
Redundant catch clause |
🔶 Warning | 29 |
Unresolved binding path when DataContext is known |
🔶 Warning | 28 |
Parameter hides member |
🔶 Warning | 27 |
Assignment is not used |
🔶 Warning | 27 |
Redundant member initializer |
🔶 Warning | 27 |
Redundant explicit type in array creation |
🔶 Warning | 24 |
Unused local variable |
🔶 Warning | 24 |
Virtual member call in constructor |
🔶 Warning | 22 |
Redundant control flow jump statement |
🔶 Warning | 20 |
Underlying type of enum is 'int' |
🔶 Warning | 19 |
Redundant argument with default value |
🔶 Warning | 18 |
Unassigned field |
🔶 Warning | 17 |
Redundant 'base.' qualifier |
🔶 Warning | 14 |
Empty general catch clause |
🔶 Warning | 13 |
Bitwise operation on enum is not marked by [Flags] attribute |
🔶 Warning | 12 |
Conditional access qualifier expression is known to be null or not null |
🔶 Warning | 11 |
Redundant name qualifier |
🔶 Warning | 11 |
Code is unreachable |
🔶 Warning | 9 |
Redundant type declaration body |
🔶 Warning | 8 |
Declaring new protected member in sealed class is the same as declaring it as private |
🔶 Warning | 7 |
Local variable hides member |
🔶 Warning | 7 |
Non-accessed local variable |
🔶 Warning | 7 |
Auto-property accessor is never used (private accessibility) |
🔶 Warning | 7 |
Access to modified captured variable |
🔶 Warning | 6 |
Unsafe context declaration is redundant |
🔶 Warning | 6 |
Unused nullable directive |
🔶 Warning | 6 |
Dereference of a possibly null reference. |
🔶 Warning | 5 |
Assignment made to same variable |
🔶 Warning | 4 |
Member initialized value ignored |
🔶 Warning | 4 |
Possible multiple enumeration |
🔶 Warning | 4 |
Redundant empty switch section |
🔶 Warning | 4 |
Empty statement is redundant |
🔶 Warning | 3 |
Possible unassigned object created by 'new' expression |
🔶 Warning | 3 |
Parameter is only used for precondition check (private accessibility) |
🔶 Warning | 3 |
Redundant class or interface specification in base types list |
🔶 Warning | 3 |
Assignment in conditional expression |
🔶 Warning | 2 |
Async function without await expression |
🔶 Warning | 2 |
Possible null reference assignment. |
🔶 Warning | 2 |
Private field can be converted into local variable |
🔶 Warning | 2 |
Field is never used |
🔶 Warning | 2 |
Variable in local function hides variable from outer scope |
🔶 Warning | 2 |
x:FieldModifier attribute requires x:Name attribute |
🔶 Warning | 2 |
Access to disposed captured variable |
🔶 Warning | 1 |
Possible 'null' assignment to non-nullable entity |
🔶 Warning | 1 |
Keyword 'new' is redundant |
🔶 Warning | 1 |
Expression is always 'true' or always 'false' |
🔶 Warning | 1 |
'??' condition is known to be null or not null |
🔶 Warning | 1 |
Empty constructor |
🔶 Warning | 1 |
Heuristically unreachable code |
🔶 Warning | 1 |
Non-accessed field |
🔶 Warning | 1 |
Non-accessed field (private accessibility) |
🔶 Warning | 1 |
Mismatch of optional parameter value in overridden method |
🔶 Warning | 1 |
Possible loss of fraction |
🔶 Warning | 1 |
Redundant 'case' label |
🔶 Warning | 1 |
Redundant empty finally block |
🔶 Warning | 1 |
Redundant nullable directive |
🔶 Warning | 1 |
Type is never used (private accessibility) |
🔶 Warning | 1 |
Unused type parameter |
🔶 Warning | 1 |
'value' parameter is not used |
🔶 Warning | 1 |
Binding mode is equal to default |
🔶 Warning | 1 |
Redundant modifiers attribute |
🔶 Warning | 1 |
Type member is never used (non-private accessibility) |
◽️ Notice | 1920 |
Member can be made private (non-private accessibility) |
◽️ Notice | 444 |
Add/remove 'this.' qualifier |
◽️ Notice | 420 |
Method return value is never used (non-private accessibility) |
◽️ Notice | 251 |
Redundant empty argument list on object creation expression |
◽️ Notice | 187 |
Remove redundant parentheses |
◽️ Notice | 166 |
Use preferred 'var' style (when type is simple) |
◽️ Notice | 164 |
Invert 'if' statement to reduce nesting |
◽️ Notice | 113 |
Redundant string interpolation |
◽️ Notice | 101 |
Field can be made readonly (private accessibility) |
◽️ Notice | 88 |
Class is never instantiated (non-private accessibility) |
◽️ Notice | 86 |
Non-accessed field (non-private accessibility) |
◽️ Notice | 73 |
Use preferred 'var' style (for built-in types) |
◽️ Notice | 73 |
Use explicit or implicit modifier definition for type members |
◽️ Notice | 63 |
Unused parameter (non-private accessibility) |
◽️ Notice | 62 |
Local variable has too wide declaration scope |
◽️ Notice | 60 |
Use preferred style of 'new' expression when created type is evident |
◽️ Notice | 59 |
Member can be made static (shared) (private accessibility) |
◽️ Notice | 45 |
Field can be made readonly (non-private accessibility) |
◽️ Notice | 39 |
Type is never used (non-private accessibility) |
◽️ Notice | 37 |
Use preferred style for trailing comma before new line in multiline lists |
◽️ Notice | 36 |
Join local variable declaration and assignment |
◽️ Notice | 34 |
Literal length can be reduced by using verbatim string |
◽️ Notice | 26 |
Use explicit or implicit modifier definition for types |
◽️ Notice | 23 |
Type member is never accessed via base type (non-private accessibility) |
◽️ Notice | 21 |
Virtual (overridable) member is never overridden (non-private accessibility) |
◽️ Notice | 21 |
Redundant 'else' keyword |
◽️ Notice | 20 |
Some values of the enum are not processed inside 'switch' statement |
◽️ Notice | 17 |
Member can be made protected (non-private accessibility) |
◽️ Notice | 15 |
Use preferred 'var' style (elsewhere) |
◽️ Notice | 14 |
Adjust modifiers declaration order |
◽️ Notice | 13 |
Unresolved binding path when DataContext is unknown |
◽️ Notice | 12 |
Convert constructor into primary constructor |
◽️ Notice | 11 |
Redundant lambda signature parentheses |
◽️ Notice | 10 |
Event is never subscribed to (non-private accessibility) |
◽️ Notice | 8 |
Array creation can be replaced with array initializer |
◽️ Notice | 8 |
Member can be made static (shared) (non-private accessibility) |
◽️ Notice | 7 |
Unassigned field (non-private accessibility) |
◽️ Notice | 7 |
Convert constructor into member initializers |
◽️ Notice | 6 |
Use compound assignment |
◽️ Notice | 6 |
Some values of the enum are not processed inside 'switch' statement and are handled via default section |
◽️ Notice | 6 |
Use preferred style of default value expression when type is evident |
◽️ Notice | 5 |
Inline 'out' variable declaration |
◽️ Notice | 5 |
Use object or collection initializer when possible |
◽️ Notice | 5 |
Merge conditional ?: expression into conditional access |
◽️ Notice | 4 |
Redundant semicolon after type or namespace declaration |
◽️ Notice | 4 |
Use preferred style of default value expression when type is not evident |
◽️ Notice | 3 |
Add/remove qualifier for static members |
◽️ Notice | 3 |
Class with virtual (overridable) members never inherited (non-private accessibility) |
◽️ Notice | 3 |
'if' statement can be rewritten as '?:' expression |
◽️ Notice | 3 |
'if-return' statement can be rewritten as 'return' statement |
◽️ Notice | 3 |
Replace 'switch' statement with 'switch' expression |
◽️ Notice | 3 |
Inline temporary variable |
◽️ Notice | 3 |
Some values of the enum are not processed inside 'switch' expression and are handled via exception in default arm |
◽️ Notice | 3 |
Use raw string |
◽️ Notice | 3 |
Convert property into auto-property |
◽️ Notice | 2 |
Convert property into auto-property (when possible) |
◽️ Notice | 2 |
Foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used |
◽️ Notice | 2 |
Type parameter could be declared as covariant or contravariant |
◽️ Notice | 2 |
Convert into 'await using' statement or declaration |
◽️ Notice | 2 |
Use preferred style for trailing comma when the last element is not followed by a new line |
◽️ Notice | 1 |
'if' statement can be rewritten as '??=' assignment |
◽️ Notice | 1 |
Convert into lambda expression |
◽️ Notice | 1 |
Convert into 'using' declaration |
◽️ Notice | 1 |
Double negation operator |
◽️ Notice | 1 |
Introduce optional parameters (non-private accessibility) |
◽️ Notice | 1 |
Merge null/pattern checks into complex pattern |
◽️ Notice | 1 |
Merge sequential checks into single conditional access check |
◽️ Notice | 1 |
Method has async overload |
◽️ Notice | 1 |
Method supports cancellation |
◽️ Notice | 1 |
Parameter is only used for precondition check (non-private accessibility) |
◽️ Notice | 1 |
Make constructor in abstract class protected |
◽️ Notice | 1 |
Struct can be made readonly |
◽️ Notice | 1 |
Parameter can be declared with the base type |
◽️ Notice | 1 |
Use index from end expression |
◽️ Notice | 1 |
Use string interpolation expression |
◽️ Notice | 1 |
Use 'with' expression to copy struct |
◽️ Notice | 1 |
💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
Check warning on line 664 in CollapseLauncher/Classes/Interfaces/Class/ProgressBase.cs
github-actions / Qodana for .NET
Access to disposed captured variable
Captured variable is disposed in the outer scope
Check warning on line 470 in CollapseLauncher/Classes/RegionManagement/RegionManagement.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 155 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 156 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 466 in CollapseLauncher/Classes/RegionManagement/RegionManagement.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 161 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 154 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check notice on line 92 in Hi3Helper.EncTool/Hashes/mhyEncTool.cs
github-actions / Qodana for .NET
Use preferred style of default value expression when type is evident
Redundant type specification
Check notice on line 94 in Hi3Helper.EncTool/Hashes/mhyEncTool.cs
github-actions / Qodana for .NET
Use preferred style of default value expression when type is evident
Redundant type specification
Check notice on line 95 in Hi3Helper.EncTool/Hashes/mhyEncTool.cs
github-actions / Qodana for .NET
Use preferred style of default value expression when type is evident
Redundant type specification
Check notice on line 234 in Hi3Helper.EncTool/Hashes/mhyEncTool.cs
github-actions / Qodana for .NET
Use preferred style of default value expression when type is evident
Redundant type specification
Check notice on line 93 in Hi3Helper.EncTool/Hashes/mhyEncTool.cs
github-actions / Qodana for .NET
Use preferred style of default value expression when type is evident
Redundant type specification
github-actions / Qodana for .NET
Use preferred style of default value expression when type is not evident
Redundant type specification
github-actions / Qodana for .NET
Use preferred style of default value expression when type is not evident
Redundant type specification
github-actions / Qodana for .NET
Use preferred style of default value expression when type is not evident
Redundant type specification
Check notice on line 6 in Hi3Helper.EncTool/Hashes/HexTool.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 19 in Hi3Helper.EncTool/Parser/SRMetadata/SRMetadataReader/Lua/SRLuaMetadata.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 1632 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 553 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/KeyboardShortcuts.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 205 in Hi3Helper.Core/Classes/Data/InvokeProp.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 574 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/KeyboardShortcuts.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order