Skip to content

Qodana

Qodana #23

GitHub Actions / Qodana for .NET completed Dec 31, 2023 in 0s

2229 new problems found by Qodana for .NET

for .NET

2229 new problems were found

Inspection name Severity Problems
XAML resource of invalid type 🔴 Failure 74
Namespace does not correspond to file location 🔶 Warning 333
Type member is never used (private accessibility) 🔶 Warning 196
Possible 'System.NullReferenceException' 🔶 Warning 159
Redundant member initializer 🔶 Warning 106
Constructor not resolved 🔶 Warning 94
Static resource not resolved 🔶 Warning 89
Possible 'null' assignment to non-nullable entity 🔶 Warning 79
Check dependency licenses 🔶 Warning 79
Redundant argument with default value 🔶 Warning 68
Auto-property accessor is never used (non-private accessibility) 🔶 Warning 59
Unused parameter (private accessibility) 🔶 Warning 49
Redundant namespace alias 🔶 Warning 36
Assignment is not used 🔶 Warning 35
Redundant catch clause 🔶 Warning 35
Missing grid column/row setter for non-first child 🔶 Warning 34
Parameter hides member 🔶 Warning 33
Redundant class or interface specification in base types list 🔶 Warning 33
Conditional access qualifier expression is known to be null or not null 🔶 Warning 32
Redundant cast 🔶 Warning 32
Unused local variable 🔶 Warning 29
Invalid XML documentation comment 🔶 Warning 26
Redundant explicit type in array creation 🔶 Warning 26
Virtual member call in constructor 🔶 Warning 24
Redundant control flow jump statement 🔶 Warning 22
Underlying type of enum is 'int' 🔶 Warning 19
Return value of [MustUseReturnValue] annotated method is not used 🔶 Warning 18
Expression is always 'true' or always 'false' 🔶 Warning 17
Local variable hides member 🔶 Warning 17
Unsafe context declaration is redundant 🔶 Warning 17
Empty general catch clause 🔶 Warning 15
Explicit argument passed to parameter with caller info attribute 🔶 Warning 15
Redundant name qualifier 🔶 Warning 13
Redundant type declaration body 🔶 Warning 13
Redundant using directive 🔶 Warning 13
Cannot resolve symbol in text argument 🔶 Warning 12
Redundant 'base.' qualifier 🔶 Warning 12
Redundant explicit size specification in array creation 🔶 Warning 12
Grid element column/row index is out of grid definition range 🔶 Warning 12
Path error 🔶 Warning 12
Remove redundant attached property setter 🔶 Warning 10
Possible 'System.InvalidOperationException' 🔶 Warning 9
Possible multiple enumeration 🔶 Warning 9
Redundant 'partial' modifier on type declaration 🔶 Warning 8
Redundant base constructor call 🔶 Warning 8
Non-accessed local variable 🔶 Warning 7
Explicit delegate creation expression is redundant 🔶 Warning 7
Auto-property accessor is never used (private accessibility) 🔶 Warning 7
Variable in local function hides variable from outer scope 🔶 Warning 7
Unresolved binding path when DataContext is known 🔶 Warning 7
Access to modified captured variable 🔶 Warning 6
'??' condition is known to be null or not null 🔶 Warning 6
Heuristically unreachable code 🔶 Warning 6
Possible overflow in unchecked context 🔶 Warning 6
Redundant lambda expression parameter type specification 🔶 Warning 6
Unused nullable directive 🔶 Warning 6
Access to a static member of a type via a derived type 🔶 Warning 5
Non-nullable member is uninitialized. 🔶 Warning 5
String.IndexOf is culture-specific (string.IndexOf(string, int) is culture-specific) 🔶 Warning 5
Assignment in conditional expression 🔶 Warning 4
Code is unreachable 🔶 Warning 4
Collection content is never queried (non-private accessibility) 🔶 Warning 4
Expression is always 'true' or 'false' according to nullable reference types' annotations 🔶 Warning 4
Conditional access qualifier expression is not null according to nullable reference types' annotations 🔶 Warning 4
Empty statement is redundant 🔶 Warning 4
Member initialized value ignored 🔶 Warning 4
Possible loss of fraction 🔶 Warning 4
Redundant empty switch section 🔶 Warning 4
Redundant type arguments of method 🔶 Warning 4
Possible unassigned object created by 'new' expression 🔶 Warning 3
Mismatch of optional parameter value in overridden method 🔶 Warning 3
Unassigned field 🔶 Warning 3
Unused type parameter 🔶 Warning 3
Async function without await expression 🔶 Warning 2
Possible null reference assignment. 🔶 Warning 2
Possible null reference return. 🔶 Warning 2
Co-variant array conversion 🔶 Warning 2
Method with optional or 'params' parameter is hidden by overload 🔶 Warning 2
Operator 'is'/'Type Of ... Is ...' can be used 🔶 Warning 2
Possible unintended reference comparison 🔶 Warning 2
Private field can be converted into local variable 🔶 Warning 2
Redundant 'IEnumerable.Cast<T>' or 'IEnumerable.OfType<T>' call 🔶 Warning 2
Redundant 'string.Format()' call 🔶 Warning 2
Method return value is never used (private accessibility) 🔶 Warning 2
x:FieldModifier attribute requires x:Name attribute 🔶 Warning 2
Redundant resource 🔶 Warning 2
Property value is equal to style-provided 🔶 Warning 2
Access to disposed captured variable 🔶 Warning 1
A possible null value may not be used for a type marked with [NotNull] or [DisallowNull]. 🔶 Warning 1
Cannot convert null literal to non-nullable reference type. 🔶 Warning 1
Collection content is never queried (private accessibility) 🔶 Warning 1
Collection is never updated (private accessibility) 🔶 Warning 1
Function never returns 🔶 Warning 1
Non-accessed field (private accessibility) 🔶 Warning 1
Non-accessed local variable only used to discard the 'out' parameter value 🔶 Warning 1
Return value of a method annotated with [MustDisposeResource] is never disposed 🔶 Warning 1
Redundant 'Attribute' suffix 🔶 Warning 1
Redundant boolean comparison 🔶 Warning 1
Redundant 'case' label 🔶 Warning 1
Redundant empty finally block 🔶 Warning 1
Redundant nullable directive 🔶 Warning 1
Return value of pure method is not used 🔶 Warning 1
Constant shift expression with non-zero operands results in a zero value 🔶 Warning 1
Shift expression with zero left operand equals zero 🔶 Warning 1
String.Compare is culture-specific (string.Compare(string, string, bool) is culture-specific) 🔶 Warning 1
String.LastIndexOf is culture-specific (string.LastIndexOf(string) is culture-specific) 🔶 Warning 1
Do not use object initializer for 'using' variable 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 666 in CollapseLauncher/Classes/Interfaces/Class/ProgressBase.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable

Captured variable is disposed in the outer scope

Check warning on line 155 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 156 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 554 in CollapseLauncher/Classes/RegionManagement/RegionManagement.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 161 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 550 in CollapseLauncher/Classes/RegionManagement/RegionManagement.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 154 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable

Captured variable is modified in the outer scope

Check warning on line 104 in CollapseLauncher/XAMLs/MainApp/TrayIcon.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 111 in CollapseLauncher/XAMLs/MainApp/Pages/SettingsPage.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 87 in CollapseLauncher/XAMLs/Updater/UpdaterWindow.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 199 in CollapseLauncher/XAMLs/Updater/Classes/Updater.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 212 in CollapseLauncher/XAMLs/MainApp/Pages/SettingsPage.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 134 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/InstallationConvert.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 102 in CollapseLauncher/Classes/CachesManagement/Honkai/Update.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 289 in CollapseLauncher/Classes/Interfaces/Class/ProgressBase.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 122 in Hi3Helper.EncTool/Hashes/mhyEncTool.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 111 in Hi3Helper.EncTool/Parser/KianaDispatch/KianaDispatch.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 699 in Hi3Helper.SharpHDiffPatch/Hi3Helper.SharpHDiffPatch/PatchCore/PatchCore.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 40 in Hi3Helper.Core/Classes/Logger/LoggerBase.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 1168 in CollapseLauncher/Classes/InstallManagement/BaseClass/InstallManagerBase.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 294 in CollapseLauncher/Classes/InstallManagement/GameConversionManagement.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 21 in CollapseLauncher/Classes/GameManagement/GameVersion/BaseClass/GameVersionBase.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 80 in Hi3Helper.Core/Classes/Data/Tools/SteamTool.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 63 in CollapseLauncher/Classes/CachesManagement/StarRail/Update.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 1528 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity