Reimplement HDiffMap feature on HoYoPlay #1471
307 new problems found by Qodana for .NET
Qodana for .NET
307 new problems were found
| Inspection name | Severity | Problems |
|---|---|---|
Auto-property accessor is never used (non-private accessibility) |
🔶 Warning | 86 |
RoslynAnalyzers Class is not marked partial |
🔶 Warning | 38 |
Expression is always 'true' or 'false' according to nullable reference types' annotations |
🔶 Warning | 18 |
Conditional access qualifier expression is not null according to nullable reference types' annotations |
🔶 Warning | 18 |
Remove redundant attached property setter |
🔶 Warning | 13 |
RoslynAnalyzers Project does not enable unsafe blocks |
🔶 Warning | 11 |
Possible 'System.NullReferenceException' |
🔶 Warning | 11 |
Property value is equal to style-provided |
🔶 Warning | 10 |
Redundant using directive |
🔶 Warning | 9 |
Missing grid column/row setter for non-first child |
🔶 Warning | 9 |
Collection content is never queried (non-private accessibility) |
🔶 Warning | 8 |
Access to modified captured variable |
🔶 Warning | 6 |
Non-readonly type member referenced in 'GetHashCode()' |
🔶 Warning | 6 |
Redundant cast |
🔶 Warning | 5 |
Redundant empty switch section |
🔶 Warning | 5 |
Avoid mixing of variable-length escape sequences and text |
🔶 Warning | 5 |
Parameter hides member |
🔶 Warning | 4 |
Auto-property accessor is never used (private accessibility) |
🔶 Warning | 4 |
Redundant base constructor call |
🔶 Warning | 3 |
Grid element column/row index is out of grid definition range |
🔶 Warning | 3 |
Redundant namespace alias |
🔶 Warning | 3 |
Possible 'null' assignment to non-nullable entity |
🔶 Warning | 2 |
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. |
🔶 Warning | 2 |
Expression is always 'true' or always 'false' |
🔶 Warning | 2 |
Conditional access qualifier expression is known to be null or not null |
🔶 Warning | 2 |
Member initialized value ignored |
🔶 Warning | 2 |
Assignment is not used |
🔶 Warning | 2 |
Redundant explicit type in array creation |
🔶 Warning | 2 |
Redundant control flow jump statement |
🔶 Warning | 2 |
Unused local variable |
🔶 Warning | 2 |
Virtual member call in constructor |
🔶 Warning | 2 |
Path error |
🔶 Warning | 2 |
Parameter is captured into the state of the enclosing type and its value is also passed to the base constructor. The value might be captured by the base class as well. |
🔶 Warning | 1 |
Collection is never updated (non-private accessibility) |
🔶 Warning | 1 |
Entity is only used to capture its name (non-private accessibility) |
🔶 Warning | 1 |
Underlying type of enum is 'int' |
🔶 Warning | 1 |
Non-accessed field (private accessibility) |
🔶 Warning | 1 |
Mismatch of optional parameter value in overridden method |
🔶 Warning | 1 |
Explicit delegate creation expression is redundant |
🔶 Warning | 1 |
Redundant name qualifier |
🔶 Warning | 1 |
Unsafe context declaration is redundant |
🔶 Warning | 1 |
Return type of a function can be made non-nullable |
🔶 Warning | 1 |
☁️ View the detailed Qodana report
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
Check warning on line 468 in Hi3Helper.Sophon/SophonAsset.Diff.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 595 in Hi3Helper.Sophon/SophonAsset.Download.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 478 in Hi3Helper.Sophon/SophonAsset.Diff.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 605 in Hi3Helper.Sophon/SophonAsset.Download.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 611 in Hi3Helper.Sophon/SophonAsset.Download.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 484 in Hi3Helper.Sophon/SophonAsset.Diff.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 241 in Hi3Helper.EncTool/Parser/SRMetadata/SRDispatcherInfo.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 1651 in CollapseLauncher/Classes/InstallManagement/Base/InstallManagerBase.cs
github-actions / Qodana for .NET
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context
github-actions / Qodana for .NET
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context
Check warning on line 18 in Hi3Helper.Win32/ToastCOM/Notification/NotificationServiceCallback.cs
github-actions / Qodana for .NET
Parameter is captured into the state of the enclosing type and its value is also passed to the base constructor. The value might be captured by the base class as well.
Parameter 'logger' is captured into the state of the enclosing type and its value is also passed to the base constructor. The value might be captured by the base class as well
Check warning on line 23 in Hi3Helper.EncTool/Parser/CachePatchManifest/CachePatchManifest.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'PatchAsset' is only updated but never used
Check warning on line 149 in Hi3Helper.EncTool/Parser/XMFParser/Class/XMFBlock.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'UniqueID' is only updated but never used
Check warning on line 20 in CollapseLauncher/Classes/Interfaces/Class/CommunityToolsProperty.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'OfficialToolsList' is only updated but never used
Check warning on line 28 in Hi3Helper.Win32/ShellLinkCOM/Win32FindDataW.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'cAlternateFileName' is only updated but never used
Check warning on line 22 in CollapseLauncher/Classes/Interfaces/Class/CommunityToolsProperty.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'CommunityToolsList' is only updated but never used
Check warning on line 38 in CollapseLauncher/XAMLs/MainApp/Pages/OOBE/OOBEAgreementMenu.xaml.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'MarkdownFileList' is only updated but never used
Check warning on line 22 in Hi3Helper.Win32/ShellLinkCOM/Win32FindDataW.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'cFileName' is only updated but never used
Check warning on line 29 in InnoSetupHelper/InnoSetupLogParser/Parser.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'ReservedHeaderBytes' is only updated but never used
Check warning on line 17 in Hi3Helper.Win32/ToastCOM/Notification/ToastComboBox.cs
github-actions / Qodana for .NET
Collection is never updated (non-private accessibility)
Content of collection 'Selection' is never updated
Check warning on line 178 in Hi3Helper.Sophon/SophonUpdate.cs
github-actions / Qodana for .NET
Expression is always 'true' or always 'false'
Expression is always true
Check warning on line 136 in Hi3Helper.Core/Classes/Data/Tools/SteamTool.cs
github-actions / Qodana for .NET
Expression is always 'true' or always 'false'
Expression is always true
Check warning on line 134 in Hi3Helper.Http/Legacy/Session/SessionTask.cs
github-actions / Qodana for .NET
Expression is always 'true' or 'false' according to nullable reference types' annotations
Expression is always true according to nullable reference types' annotations
Check warning on line 286 in Hi3Helper.Http/Legacy/Session/Session.cs
github-actions / Qodana for .NET
Expression is always 'true' or 'false' according to nullable reference types' annotations
Expression is always true according to nullable reference types' annotations
github-actions / Qodana for .NET
Expression is always 'true' or 'false' according to nullable reference types' annotations
Expression is always true according to nullable reference types' annotations