Adi countries react api #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamir198
requested changes
Jan 4, 2025
| return ( | ||
| // TODO: Country component | ||
| <div>Country</div> | ||
| <div className='country' onClick={onClick}> |
| <li> | ||
| <strong>Population: </strong> | ||
| <span className='country-population'>{countryData.population}</span> | ||
| </li> |
There was a problem hiding this comment.
Style via css and not via html tags
| <div className="dropdown-body"> | ||
| <ul> | ||
| <li data-region="all">All</li> | ||
| <li data-region="africa">Africa</li> |
There was a problem hiding this comment.
Consider change this hardcoded tags into a map function
|
|
||
| export const Modal = ({ countryData, onClose }) => { | ||
| if (!countryData) return null; | ||
|
|
There was a problem hiding this comment.
Why would a component return null? Wouldn't it be better to return fallback jsx?
| <div className="modal-overlay" onClick={onClose}> | ||
| <div className="modal-content" onClick={(e) => e.stopPropagation()}> | ||
| {/* <button class="close-button" onclick="closeModal()">X</button> */} | ||
| <div className="country-flag"> |
| font-size: 30px; | ||
| margin-top: -15px; | ||
| color: #333; | ||
| margin-bottom: 30px; |
| } | ||
|
|
||
| /* אנימציות */ | ||
| @keyframes fadeIn { |
There was a problem hiding this comment.
Never add comments in Hebrew. Or any comment on simple css line
| const data= await response.json(); | ||
|
|
||
| console.log("data fetched"); | ||
|
|
There was a problem hiding this comment.
When merging code to main we don`t want to add console.log
| population: country.population, | ||
| region: country.region, | ||
| capital: country.capital ? country.capital[0] :"N/A", | ||
| flag: country.flags.svg, |
There was a problem hiding this comment.
You can also write it like this :
country.capital?.[0] ?? "N/A",| {selectedCountry&& ( | ||
| <> | ||
| {console.log("Modal is rendering for:", selectedCountry)} | ||
| <Modal countryData={selectedCountry} onClose={closeModal}/> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.