done working on countries #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamir198
requested changes
Dec 23, 2024
| @@ -0,0 +1,24 @@ | |||
| function getCountry() { | |||
| document.addEventListener("DOMContentLoaded", () => { | |||
| const countryDetails = JSON.parse(localStorage.getItem("countryDetails")); | |||
There was a problem hiding this comment.
Couple of things regarding this function :
- Make sure that this function is only doing 1 thing, right now the function really overloaded with different things to do
- You can extract the localStorage logic into service and call the service methods from there
- Do not repeat
document.querySelector(".country-flag img"), save this inside a variable, and one more thing that you should do is to style your element via css classes and not js - Do not use
innerHTML, it is a dangerous method
|
|
||
|
|
||
| fetch('./CountriesData.json') | ||
| .then((response) => response.json()) |
There was a problem hiding this comment.
Hardcoded strings should be saved inside constant file, this will enable you to add or change things inside 1 place (Other places might need this string as well)
| .catch((error) => console.error('Error fetching countries:', error)); | ||
|
|
||
| //----------------render the countries function---------------- | ||
|
|
There was a problem hiding this comment.
You don`t need this comment because the name of the function makes it super clear
| function renderCountreis(countries){ | ||
|
|
||
| countriesGrid.innerHTML = ''; | ||
|
|
There was a problem hiding this comment.
Same comment in this function about innerHTML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.