Fix crash caused by Observables that send a value synchronously while…

… being subscribed to. Combine requires receiving the subscription event before receiving and value events.
CombineCommunity · Jun 26, 2019 · 82c35bc · 82c35bc
1 parent 86d24d7
commit 82c35bc
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Sources/Rx+Combine/Observable+Combine.swift b/Sources/Rx+Combine/Observable+Combine.swift
@@ -14,10 +14,12 @@ public extension ObservableConvertibleType {
     /// so the Observable pushes events to the Publisher.
     var publisher: AnyPublisher<Element, Swift.Error> {
         AnyPublisher<Element, Swift.Error> { subscriber in
+            let disposable = SingleAssignmentDisposable()
             subscriber.receive(
-                subscription: RxSubscription(disposable: self.asObservable()
-                                                             .subscribe(subscriber.pushRxEvent))
+                subscription: RxSubscription(disposable: disposable)
             )
+            disposable.setDisposable(self.asObservable()
+                                         .subscribe(subscriber.pushRxEvent))
         }
     }