Extend date range config options - start/end date, submit-on-change #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add tests for this? |
RKushnir
force-pushed
the
date-range-config
branch
2 times, most recently
from
3b6430f to
2d78a8b
Compare
|
@dziemba done |
|
🍄 |
| @@ -1,3 +1,9 @@ | |||
| #= require jquery | |||
There was a problem hiding this comment.
Why the includes here? Aren't they in the global ui_c coffee file already?
https://github.com/ad2games/ui_components/blob/master/app/assets/javascripts/ui_components.js.erb
There was a problem hiding this comment.
I'll remove them for now.
It seems there's a code migration in progress here, so new tests use a layout which only loads the component's js code(without jquery etc). Thus the need to require the dependencies(e.g. https://github.com/ad2games/ui_components/blob/115e6840ad043b75315e88c8dfbf0e696c00fdcc/app/cells/select/select.coffee)
But my attempt to go the "new way" failed because of the html-escaping bug in the slim.
RKushnir
force-pushed
the
date-range-config
branch
from
2d78a8b to
9bd55fb
Compare
RKushnir
added a commit
that referenced
this pull request
Jan 6, 2016
Extend date range config options - start/end date, submit-on-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass config options for initial start/end date.
Support submit-on-change — submit the enclosing form when the selected date range changes.
Required for https://github.com/ad2games/nevaly/pull/95