Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix io slot label overwrite by i18n #1904

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix io slot label overwrite by i18n #1904

merged 2 commits into from
Dec 13, 2024

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Dec 13, 2024

Resolves #1899

Ref litegraph PR: Comfy-Org/litegraph.js#376

This PR address 2 issues:

  • User rename of node slot get overwritten on workflow reload
  • i18n translated names get serialized into workflow (Exported workflows being different when in different locales)

Note

Because LGraph.serialize is used to precisely determine the graph rendering with, the localized name is only removed when ComfyUI's save/export are triggered.

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei requested review from a team as code owners December 13, 2024 20:06
@huchenlei huchenlei changed the title Fix io label overwrite Fix io slot label overwrite by i18n Dec 13, 2024
@huchenlei huchenlei added the i18n Anything related to translation label Dec 13, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@comfyorg/[email protected] network 0 2.42 MB k1oride

🚮 Removed packages: npm/@comfyorg/[email protected]

View full report↗︎

@huchenlei huchenlei merged commit a99f637 into main Dec 13, 2024
11 checks passed
@huchenlei huchenlei deleted the fix_io_label_overwrite branch December 13, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything related to translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Renamed input/output slots are reset on refresh
1 participant